Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower z index of scale border so it draws behind the chart elements again #9412

Closed
wants to merge 12 commits into from
Closed

lower z index of scale border so it draws behind the chart elements again #9412

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
560d59d
lower z index of scale border so it draws behind the chart elements a…
LeeLenaleee Jul 13, 2021
750c38b
lower default tick and grid z indez to -1 instead because color descr…
LeeLenaleee Jul 14, 2021
df49447
Limit Math.asin inputs to the range [-1, 1] (#9410)
etimberg Jul 14, 2021
7105d90
revert label z-index back to original, use valueordefault for grid z …
LeeLenaleee Jul 14, 2021
fb45d8a
Update a failing fixture (#9414)
kurkle Jul 14, 2021
11045a7
Fix center axis title positions (#9413)
etimberg Jul 15, 2021
9473351
lower z index of scale border so it draws behind the chart elements a…
LeeLenaleee Jul 13, 2021
ad47217
lower default tick and grid z indez to -1 instead because color descr…
LeeLenaleee Jul 14, 2021
a9b7575
revert label z-index back to original, use valueordefault for grid z …
LeeLenaleee Jul 14, 2021
5252ab9
add test js file
LeeLenaleee Jul 15, 2021
b262c2b
increase color and with of border so test will pick difference up
LeeLenaleee Jul 15, 2021
330b51b
Merge branch 'fix/axis-line-behind-bubble' of https://github.com/LeeL…
LeeLenaleee Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/core.scale.js
View file
Open in desktop
Expand Up @@ -1599,8 +1599,8 @@ export default class Scale extends Element {
_layers() {
const me = this;
const opts = me.options;
const tz = opts.ticks && opts.ticks.z || 0;
const gz = opts.grid && opts.grid.z || 0;
const tz = opts.ticks && opts.ticks.z || -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use valueOrDefault, because you can't define z as 0 now. Does the tick z need to be changed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test wont fail if it isnt changed, but I thought since they where at the same z-index it would be logic to keep them at the same z-index

const gz = opts.grid && opts.grid.z || -1;

if (!me._isVisible() || me.draw !== Scale.prototype.draw) {
// backward compatibility: draw has been overridden by custom scale
Expand Down