Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiations Wrapped with One Port #1889

Open
bkueffle opened this issue Apr 24, 2023 · 2 comments · May be fixed by #1909
Open

Instantiations Wrapped with One Port #1889

bkueffle opened this issue Apr 24, 2023 · 2 comments · May be fixed by #1909
Assignees
@jbylicki
Labels
formatter Verilog code formatter issues

Comments

@bkueffle
Copy link

Behavior around module instantiation wrapping doesn't seem desirable. Whenever only one port and/or parameter is given, the instantiation is done on one line (as long as it fits on the line). If 2 ports or 2 parameters are given, then the instantiation style is wrapped, even if it does fit on one line.

Test case

  module_name #(
      .Param1(Param1)
  ) only_one_param_or_port (
      .port_i(a_i)
  );

  module_name #(
      .Param1(Param1),
      .Param2(Param2)
  ) two_or_more_param_or_ports (
      .port_i(a_i)
  );

  module_name fits_on_one_line (
      .port_i(a_i),
      .port_o(b_o)
  );

Actual output

  module_name #(.Param1(Param1)) only_one_param_or_port (.port_i(a_i));

  module_name #(
      .Param1(Param1),
      .Param2(Param2)
  ) two_or_more_param_or_ports (
      .port_i(a_i)
  );

  module_name fits_on_one_line (
      .port_i(a_i),
      .port_o(b_o)
  );

Include any possible diagnostic messages from the formatter.

The output I desire

I always want to wrap my instantiations, even if it fits on one line.

  module_name #(
      .Param1(Param1)
  ) only_one_param_or_port (
      .port_i(a_i)
  );

  module_name #(
      .Param1(Param1),
      .Param2(Param2)
  ) two_or_more_param_or_ports (
      .port_i(a_i)
  );

  module_name fits_on_one_line (
      .port_i(a_i),
      .port_o(b_o)
  );

Another Output Option that Some May Prefer

Some may prefer making the instantiation fit on one line if it is <= the character limit.

  module_name fits_on_one_line (.port_i(a_i), .port_o(b_o));
@bkueffle bkueffle added the formatter Verilog code formatter issues label Apr 24, 2023
@hzeller
Copy link
Collaborator

hzeller commented Apr 24, 2023

Thanks for the report. Yes indeed, these things should be more configurable. So three choices would be good: multi-line always, single-line iff one parameter, single-line if all parameters fit within line length.

@jbylicki Since you're on a roll currently with formatter updates, is this something that interests you ?

@bkueffle
Copy link
Author

Yeah to prevent bloat I think just two options would suffice:

Multi-line always.
Single-line if all parameters & ports fit within line length.

single-line iff one parameter and/or port seems like a bug/side effect of some other rule. I don't know any style that would use this.

@jbylicki jbylicki linked a pull request May 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbylicki jbylicki

Labels
formatter Verilog code formatter issues
Projects
Verible - release planning
Status: v1.1 - features
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added an always_wrap_module_instantiations flag antmicro/verible
3 participants
@hzeller @bkueffle @jbylicki