Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language Server: implement textDocument/hover #1187

Open
hzeller opened this issue Feb 11, 2022 · 2 comments · May be fixed by #1922
Open

Language Server: implement textDocument/hover #1187

hzeller opened this issue Feb 11, 2022 · 2 comments · May be fixed by #1922
Labels
language-server Language server related issues

Comments

@hzeller
Copy link
Collaborator

hzeller commented Feb 11, 2022

The Hover request should return some information that can be useful in the context

Ideas:

  • Variables: type if available (maybe requires symbol table, but could probably be more simply derived; register/wire/parameter/localparam; if possible to determine without going too much in elaboration-weeds: width. Input, output ?)
  • Blocks: when hovering over the end block - if this is a labelled block, name of the label
  • generalized to endmodule, endfunction... name of the corresponding thing.

Some simple things can probably be relatively easily be derived, others might need symbol table.
@hzeller hzeller added the language-server Language server related issues label Feb 11, 2022
hzeller added a commit to hzeller/verible that referenced this issue Feb 11, 2022
@hzeller
Sketch out next steps in language server features
7949034 
  * File feature requests chipsalliance#1187, chipsalliance#1188, chipsalliance#1189, chipsalliance#1190
  * Reference these in the README to easily follow progress
  * Write JSON RPC proocol definition for these features.

Signed-off-by: Henner Zeller <hzeller@google.com>
@hzeller hzeller mentioned this issue Feb 11, 2022
Merged
hzeller added a commit to hzeller/verible that referenced this issue Feb 11, 2022
@hzeller
Sketch out next steps in language server features
c6e3d4c 
  * File feature requests chipsalliance#1187, chipsalliance#1188, chipsalliance#1189, chipsalliance#1190
  * Reference these in the README to easily follow progress
  * Write JSON RPC protocol definition for these features.

Signed-off-by: Henner Zeller <hzeller@google.com>
@glatosinski glatosinski linked a pull request May 16, 2023 that will close this issue
Draft
7 tasks
@Saad-Mufti
Copy link

Is there any plan for adding hover info for literals, say to show what a binary literal is in hex or decimal? Or utility functions (e.g. $clog2)/other keywords (always_ff), to show parameters + basic info? If not I'd be willing to take a stab at it.

@hzeller
Copy link
Collaborator Author

hzeller commented Jan 5, 2024

There are many ideas that could be implemented, alas there is not enough time.
So yes, please take a stab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language-server Language server related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[LSP] Initial support for textDocument/hover request antmicro/verible
2 participants
@hzeller @Saad-Mufti