Skip to content

Commit

Permalink
Revert "deps: Upgrade ESLint to ^6.8.0, and related deps."
Browse files Browse the repository at this point in the history
This reverts commit 01593b3.

We should redo the upgrade when we can take a version of
`prettier-eslint` in which `core-js` is re-introduced as a
dependency; prettier/prettier-eslint#348 is the closest issue for
that. The commands listed in 01593b3 should make it easy to redo
the upgrade mechanically, and without having to think about rebase
conflicts.

The version (11.0.0) of `prettier-eslint` that we got in 01593b3
was affected by a bug with symptoms quite similar to ones we see
with the Prettier VSCode extension (a.k.a. `esbenp.prettier-vscode`)
at version 5 and above [1]. We'll have to resolve the problem with
the VSCode extension at some point (see discussion for a likely way
we'll do that), since we can't assume it will always be fine to stay
below version 5, and version 5 causes problems because of an
intentional design change.

But, from experimentation, it appears that this time the problem is
just caused by `prettier-eslint` not having the right version of
`core-js`. At 10.1.0, the latest version before the problem starts
happening, we can remove
`node_modules/prettier-eslint/node_modules/core-js`, and we see the
problem. Version 10.1.1, which ships with the problem, removed
`core-js` as a dependency, and an issue with a different bad symptom
(prettier/prettier-eslint#348) was soon filed, and a PR
(prettier/prettier-eslint#359) came along to add `core-js` back in.

We can't just back up to version 10.1.0, because then we're at risk
of it not working with ESLint 6 [2]. So, just revert the entire
ESLint 6 upgrade.

[1] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/SOLVED.3A.20Prettier.20auto-formatting/near/893164
[2] prettier/prettier-eslint#338 (comment)
  • Loading branch information
chrisbobbe authored and gnprice committed Aug 11, 2020
1 parent 7a23ac7 commit e3e8d9a
Show file tree
Hide file tree
Showing 2 changed files with 163 additions and 567 deletions.
21 changes: 10 additions & 11 deletions package.json
Expand Up @@ -42,7 +42,6 @@
"blueimp-md5": "^2.10.0",
"color": "^3.0.0",
"date-fns": "^1.29.0",
"eslint-plugin-react-hooks": "^4.0.8",
"expo-apple-authentication": "^2.1.1",
"expo-application": "^2.1.1",
"expo-screen-orientation": "^1.0.0",
Expand Down Expand Up @@ -99,15 +98,15 @@
"babel-eslint": "^10.0.3",
"babel-plugin-transform-remove-console": "^6.9.4",
"deep-freeze": "^0.0.1",
"eslint": "^6.8.0",
"eslint-config-airbnb": "^18.2.0",
"eslint-config-prettier": "^6.11.0",
"eslint-plugin-flowtype": "^4.7.0",
"eslint-plugin-import": "^2.22.0",
"eslint-plugin-jest": "^22.21.0",
"eslint-plugin-jsx-a11y": "^6.3.1",
"eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-react": "^7.20.5",
"eslint": "^5.16.0",
"eslint-config-airbnb": "^17.1.1",
"eslint-config-prettier": "^6.0.0",
"eslint-plugin-flowtype": "^3.9.0",
"eslint-plugin-import": "^2.18.1",
"eslint-plugin-jest": "^22.11.1",
"eslint-plugin-jsx-a11y": "^6.2.3",
"eslint-plugin-prettier": "^3.1.0",
"eslint-plugin-react": "^7.14.2",
"flow-bin": "^0.105.0",
"flow-coverage-report": "^0.6.0",
"flow-typed": "^2.4.0",
Expand All @@ -121,7 +120,7 @@
"lolex": "^5.1.1",
"metro-react-native-babel-preset": "^0.56.0",
"prettier": "^1.18.2",
"prettier-eslint": "^11.0.0",
"prettier-eslint": "^9.0.0",
"prettier-eslint-cli": "^5.0.0",
"prop-types": "^15.7.2",
"react-dom": "16.9.0",
Expand Down

0 comments on commit e3e8d9a

Please sign in to comment.