Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chromatic script that can be added to package.json #337

Merged
merged 2 commits into from May 18, 2021
Merged

Fix chromatic script that can be added to package.json #337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecfc8d2
Simplify way we generate the chromatic script
ghengeveld May 7, 2021
e8b8205
Merge branch 'next' into fix-add-chromatic-script
ghengeveld May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions bin/lib/checkPackageJson.js
View file
Open in desktop
Expand Up @@ -18,10 +18,7 @@ export default async function checkPackageJson({ log, options, packageJson, pack
if (!json.scripts) json.scripts = {};
if (findScript(json.scripts)) return;

const scriptCommand = `${`npx chromatic ${options.originalArgv.slice(2).join(' ')}`
.replace(/--project-token[= ]\S+/, '')
.replace(/--app-code[= ]\S+/, '')
.trim()} --project-token ${options.projectToken}`;
const scriptCommand = `npx chromatic ${options.originalArgv.join(' ')}`;

log.info('');
if (await confirm(scriptNotFound(scriptName))) {
Expand Down