Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump github.com/prometheus/client_golang" #19398

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 11, 2022

The commit reverted in #19395 was the wrong one. The tests were fixed by #19399

Signed-off-by: André Martins andre@cilium.io

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 11, 2022
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Apr 11, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 11, 2022
@aanm aanm changed the title Revert "metrics: Add go_* metrics and go_build_info metrics" Revert "build(deps): bump github.com/prometheus/client_golang" Apr 11, 2022
@aanm aanm marked this pull request as ready for review April 11, 2022 15:20
@aanm aanm requested a review from a team as a code owner April 11, 2022 15:20
@aanm aanm requested a review from rolinh April 11, 2022 15:20
@aanm aanm added the release-blocker/1.12 This issue will prevent the release of the next version of Cilium. label Apr 11, 2022
…7.1 to 1.28.0""

This reverts commit bbe2dc1.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm merged commit 31b9446 into master Apr 11, 2022
@aanm aanm deleted the pr/fix-promtool branch April 11, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker/1.12 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants