Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smoke tests by filtering out go_* metrics from metrics linting #19399

Merged
merged 1 commit into from Apr 11, 2022
Merged

Fix smoke tests by filtering out go_* metrics from metrics linting #19399

merged 1 commit into from Apr 11, 2022

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Apr 11, 2022

See #19398 and prometheus/prometheus#10574 for the original issue this aims to work-around.

@chancez
Fix smoke tests by filtering out go_* metrics from metrics linting
3e22ed7 
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez requested review from a team as code owners April 11, 2022 15:52
@chancez chancez requested a review from nbusseneau April 11, 2022 15:52
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 11, 2022
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Apr 11, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 11, 2022
@sayboras sayboras added area/CI Continuous Integration testing issue or flake dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 11, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 11, 2022
sayboras
sayboras approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround is looking good to me 💯

.github/workflows/tests-smoke.yaml Show resolved Hide resolved
@aanm aanm merged commit 9e19fc0 into cilium:master Apr 11, 2022
@aanm aanm mentioned this pull request Apr 11, 2022
Merged
@chancez chancez deleted the pr/chancez/handle_go_metrics_naming_lint branch April 11, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@sayboras sayboras sayboras approved these changes

@nbusseneau nbusseneau Awaiting requested review from nbusseneau nbusseneau was automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chancez @aanm @sayboras