Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smoke tests by filtering out go_* metrics from metrics linting #19399

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix smoke tests by filtering out go_* metrics from metrics linting #19399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests-smoke.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,9 @@ jobs:
tar xzvf prometheus-${PROM_VERSION}.linux-amd64.tar.gz prometheus-${PROM_VERSION}.linux-amd64/promtool
rm -f prometheus-${PROM_VERSION}.linux-amd64.tar.gz
sudo mv prometheus-${PROM_VERSION}.linux-amd64/promtool /usr/bin
cat metrics.prom | promtool check metrics
# filter go_ metrics which do not conform to the _total convention with gauges
# See https://github.com/prometheus/prometheus/issues/10574
cat metrics.prom | grep -v 'go_' | promtool check metrics
sayboras marked this conversation as resolved.
Show resolved Hide resolved

- name: Capture cilium-sysdump
if: ${{ failure() }}
Expand Down