Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor has signed CLA but sill shows check as "pending" on pull request #352

Closed
decause opened this issue Jul 11, 2018 · 13 comments
Closed

Comments

@decause
Copy link

decause commented Jul 11, 2018

URL to the linked Repo/Org: twitter/chill#314

Steps to reproduce the problem:

  1. I double checked at our export list and can confirm that the user has signed the CLA, but the check is still "pending" on the pull request.

What is the expected result?
The check should pass, and the dot should be green.

What happens instead?
The check is pending, and the dot is yellow.

@decause
Copy link
Author

decause commented Jul 11, 2018

It seems like the bot is looking for "Zanfeng Feng" and the entry in our export is fengzanfeng?

@KharitonOff
Copy link
Contributor

@decause yes, this happens often. Some contributors doesn't use the same e-mail for their commits as they have stored in their GitHub account. That's why we placed the info in the comment from CLA Assistant

Zanfeng Feng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

there is also a link to the GitHub documentation with proposal how to solve this https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user

@akki-jat
Copy link

akki-jat commented Aug 3, 2018

I am facing the same problem. I have already added account from which I committed to my GitHub account.
Even though it is not reflecting.

@KharitonOff
Copy link
Contributor

@akki-jat If you have already added the email you have used in the commit to your GitHub account, then the CLA Assistant needs to be triggered in order to recheck the PR. It can be done either via a PR webhook (just update the PR by adding a comment or a commit) or via a "Recheck PR" in the CLA Assistant ui (only the project owner can do it)

@akki-jat
Copy link

akki-jat commented Aug 3, 2018

@KharitonOff I added both comment and commit after updating the email, but even thought it is showing pending.
And I can't confirm with "Recheck PR" option.

@KharitonOff
Copy link
Contributor

@akki-jat can you provide me the url of the PR, please?

@akki-jat
Copy link

akki-jat commented Aug 3, 2018

@KharitonOff
Copy link
Contributor

@akki-jat I've reported your issue to GitHub and will let you know as soon they'll contact me. It is definitely not an issue with the CLA Assistant, we rely on the data, provided by GH. If GH can not recognise you as a committer, then CLA Assistant can't do it to either.

@akki-jat
Copy link

akki-jat commented Aug 3, 2018

@KharitonOff ok, thanks.

@KharitonOff
Copy link
Contributor

@akki-jat I've just forwarded you the response from GitHub via email

@akki-jat
Copy link

akki-jat commented Aug 5, 2018

@KharitonOff thanks, issue is resolved.

@yanrongzhen
Copy link

alibaba/fastjson#4185 this pr also have the same problems, always in pending status.

@KharitonOff
Copy link
Contributor

@yanrongzhen your issue is resolved now, right? I see you have created a new PR, that has passed the check successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants