Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override protobuf serializer copy method #314

Conversation

fengzanfeng
Copy link
Contributor

Because the [copy] method in parent class throw KryoException forever, this is very inefficient for protobuf message.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Zanfeng Feng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@johnynek
Copy link
Collaborator

thanks! if you sign the CLA I will merge.

@fengzanfeng
Copy link
Contributor Author

@johnynek I have signed the CLA for twitter/chill, thanks.

@johnynek
Copy link
Collaborator

huh, the bot things you have not. Can you click on the details link next to the yellow dot in the checks section?

@fengzanfeng
Copy link
Contributor Author

I have done as you suggested. Is it ok now? @johnynek

@johnynek
Copy link
Collaborator

@decause can you give any help here? It seems like the CLA bot is not working correctly.

@fengzanfeng
Copy link
Contributor Author

@decause could you giving help?

@decause
Copy link

decause commented Jul 11, 2018

I checked our list and can confirm that @fengzanfeng has signed the CLA as of 6/20/2018, even though it's not showing up here for some reason.

Go ahead an merge manually for now @johnynek and I'll follow-up with upstream to see what the issue is with the checks.

🚢

@decause
Copy link

decause commented Jul 11, 2018

submitted here: cla-assistant/cla-assistant#352

@johnynek johnynek merged commit 5515ba8 into twitter:develop Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants