fix: Focus on ArgRequiredElseHelp instead of SubcommandRequiredElseHelp #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showing help on `$ cmd` makes sense but when an arg is present but not subcommand, that suggests the user missed something, so we should show a more specific error message. Compatibility note: Settings we apply for subcommands have changed. Fixes clap-rs#3280
With clap-rs#3280 resolved where we can use `SubcommandRequired | ArgRequiredElseHelp`, this setting offers little value but requires we track required subcommands with two different settings. Deprecating as the cost is not worth the benefit anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code now and opens the door for simplifying the code in the future since
subcommand_required(true).arg_required_else_help(true)offers a better experience while not requiring we track required arguments with two different settings.This does mean the derive has a different set of settings applied. This will break people making assumptions about what settings we apply.
Fixes #3280