Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Focus on ArgRequiredElseHelp instead of SubcommandRequiredElseHelp #3455

Closed
wants to merge 7 commits into from
Closed

fix: Focus on ArgRequiredElseHelp instead of SubcommandRequiredElseHelp #3455

wants to merge 7 commits into from

Commits on Feb 11, 2022

  1. perf(validate): Remove unnecesarry walking of args

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    9824f8d View commit details
    Browse the repository at this point in the history

  2. refactor(validate): Drop us to one req check

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8e5ce6c View commit details
    Browse the repository at this point in the history

  3. refactor(validate): Clarify subcmd check intent

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    c0fd675 View commit details
    Browse the repository at this point in the history

  4. fix(validate): Give precedence to ArgRequiredElseHelp

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    e8e4691 View commit details
    Browse the repository at this point in the history

  5. docs: Stop demonstrating SubcommandRequiredElseHelp

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8f201d8 View commit details
    Browse the repository at this point in the history

  6. fix(derive): Give more meaningful error on missing subcommand 

    Showing help on `$ cmd` makes sense but when an arg is present but not
subcommand, that suggests the user missed something, so we should show a
more specific error message.

Compatibility note: Settings we apply for subcommands have changed.

Fixes clap-rs#3280
    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    d127305 View commit details
    Browse the repository at this point in the history

  7. fix: Deprecate SubcommandRequiredElseHelp 

    With clap-rs#3280 resolved where we can use `SubcommandRequired |
ArgRequiredElseHelp`, this setting offers little value but requires we
track required subcommands with two different settings.  Deprecating as
the cost is not worth the benefit anymore.
    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    1c0e079 View commit details
    Browse the repository at this point in the history