Turn config into a singleton #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcoe
force-pushed
the
singleton-config
branch
2 times, most recently
from
cccef90
to
0186f20
Compare
samcoe
commented
May 31, 2022
| // TODO: Make global config singleton using sync.Once | ||
| // so as not to read from file every time. | ||
| return load(generalConfigFile(), hostsConfigFile()) | ||
| var Read = func() (*Config, error) { |
There was a problem hiding this comment.
Changing this to be a variable for testing purposes seemed to be the best approach here to bypass having to deal with sync.Once in tests.
This was referenced Jun 8, 2022
mislav
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #44.
Changes in this PR:
ConfigDir,StateDir,DataDirtokenForHostReadthe loaded config will be cached in a global singleton variable so that subsequent calls toReadwill not need to access the filesystem again.cc cli/cli#5560