Extract table printer from CLI #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcoe
approved these changes
Aug 8, 2022
example_gh_test.go
Outdated
Comment on lines
185
to
186
| fmt.Fprintln(os.Stderr, err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
I think this is equivalent to log.Fatal(err).
pkg/tableprinter/table.go
Outdated
| Render() error | ||
| } | ||
|
|
||
| // WithTruncate sets the truncation function for the field. Pass nil to disable truncation for this value. |
There was a problem hiding this comment.
If no WithTruncate function is specified for a field will the the field be truncated as necessary to fit the output width?
There was a problem hiding this comment.
That's a good question! Every field is automatically truncated by default. I will try to point this out in the docs
pkg/term/env.go
Outdated
|
|
||
| // ColorEnabled reports whether it's safe to output ANSI color sequences, depending on IsTerminalOutput and | ||
| // environment variables. | ||
| func (t Term) ColorEnabled() bool { |
There was a problem hiding this comment.
Do we want to name this IsColorEnabled to match naming scheme of IsTerminalOutput?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a TablePrinter that can be used to print column-formatted tabular data to the terminal and the same data in TSV format to redirect to files or scripts.
TODO