Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pages-shared 'wrangler pages dev' #1788

Merged
merged 4 commits into from Sep 12, 2022
Merged

pages-shared 'wrangler pages dev' #1788

merged 4 commits into from Sep 12, 2022

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Sep 7, 2022 •
edited

Fixes #1001

Blocked by cloudflare/miniflare#358 #1795 Ready to go! 🎉

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022 •
edited

🦋 Changeset detected

Latest commit: 3ef723b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GregBrimble GregBrimble force-pushed the pages-shared-assets-binding branch 3 times, most recently from 82d5529 to 187ca14 Compare September 7, 2022 18:16
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022 •
edited

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3022676615/npm-package-wrangler-1788

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1788/npm-package-wrangler-1788

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3022676615/npm-package-wrangler-1788 dev path/to/script.js

@GregBrimble GregBrimble changed the title Pages shared assets binding pages-shared 'wrangler pages dev' Sep 7, 2022
@GregBrimble GregBrimble force-pushed the pages-shared-assets-binding branch 2 times, most recently from 48f8c98 to ab31b9b Compare September 8, 2022 13:23
@codecov
Copy link

codecov bot commented Sep 8, 2022 •
edited

Codecov Report

Merging #1788 (1049e36) into main (c17f6d3) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 1049e36 differs from pull request most recent head 3ef723b. Consider uploading reports for the commit 3ef723b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1788      +/-   ##
==========================================
+ Coverage   75.36%   75.51%   +0.14%     
==========================================
  Files          97       98       +1     
  Lines        7076     7160      +84     
  Branches     1849     1882      +33     
==========================================
+ Hits         5333     5407      +74     
- Misses       1743     1753      +10
Impacted Files Coverage Δ
packages/wrangler/src/pages/hash.tsx 100.00% <100.00%> (ø)
packages/wrangler/src/pages/upload.tsx 85.13% <100.00%> (-0.30%) ⬇️
packages/wrangler/src/dialogs.tsx 14.00% <0.00%> (-1.56%) ⬇️
packages/wrangler/src/init.ts 96.09% <0.00%> (-1.08%) ⬇️
packages/wrangler/src/publish.ts 91.83% <0.00%> (-0.21%) ⬇️
...ages/wrangler/src/__tests__/helpers/mock-cfetch.ts 94.93% <0.00%> (-0.07%) ⬇️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

@GregBrimble GregBrimble marked this pull request as ready for review September 8, 2022 14:00
Skye-31
Skye-31 reviewed Sep 8, 2022
View reviewed changes
packages/wrangler/src/miniflare-cli/assets.ts
Comment on lines +160 to +165
if (
contentRequest.cf &&
"clientAcceptEncoding" in contentRequest.cf &&
contentRequest.cf.clientAcceptEncoding
) {
rawAcceptEncoding = contentRequest.cf.clientAcceptEncoding as string;
Copy link
Contributor

@Skye-31 Skye-31 Sep 8, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right in thinking that this may resolve #370 if this code is also used in production?

(perhaps #165 (comment) too?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite. We need to also assume a default "identity" accept-encoding if coming from env.ASSETS.fetch(), but that is something we'll be able to tackle shortly :)

I think it will probably help that comment on 165 though :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress!

@GregBrimble GregBrimble force-pushed the pages-shared-assets-binding branch 2 times, most recently from 1850af6 to 1049e36 Compare September 9, 2022 13:14
@GregBrimble GregBrimble merged commit 152a1e8 into main Sep 12, 2022
@GregBrimble GregBrimble deleted the pages-shared-assets-binding branch September 12, 2022 11:51
@github-actions github-actions bot mentioned this pull request Sep 12, 2022
Merged
@GregBrimble GregBrimble mentioned this pull request Sep 12, 2022
Closed
@Skye-31 Skye-31 mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skye-31 Skye-31 Skye-31 left review comments

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

@threepointone threepointone Awaiting requested review from threepointone

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Pages header response differences - prod vs local differences
3 participants
@GregBrimble @CarmenPopoviciu @Skye-31