-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve entrypoint filename when building a Worker with --outdir #2836
Conversation
🦋 Changeset detectedLatest commit: 92a3118 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4355114628/npm-package-wrangler-2836 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2836/npm-package-wrangler-2836 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4355114628/npm-package-wrangler-2836 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4355114628/npm-package-cloudflare-pages-shared-2836 Note that these links will no longer work once the GitHub Actions artifact expires. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the surface but CI does not agree...
a54d158
to
99324ea
Compare
Codecov Report
@@ Coverage Diff @@
## main #2836 +/- ##
==========================================
+ Coverage 73.93% 73.96% +0.03%
==========================================
Files 166 166
Lines 10250 10251 +1
Branches 2744 2745 +1
==========================================
+ Hits 7578 7582 +4
+ Misses 2672 2669 -3
|
d626f62
to
3a27392
Compare
6c4aa66
to
e24ebcb
Compare
3a27392
to
6f79b09
Compare
0c91902
to
95b886d
Compare
8e637ff
to
9295957
Compare
3bd0c95
to
1e4d8fe
Compare
cc6b8e7
to
b410c49
Compare
1e4d8fe
to
8942f0b
Compare
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
def59b0
to
92a3118
Compare
What this PR solves / how to test:
npx wrangler publish --dry-run --outdir dist --assets public src/foo.ts
should produce adist/foo.js
rather thandist/<internal-facade-name>.js
Associated docs issues/PR:
--outdir
#2835Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
Fixes # [insert issue number].