Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler]: Fix local mode force on pages dev #2931

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

Skye-31
Copy link
Contributor

@Skye-31 Skye-31 commented Mar 21, 2023

Fixes N/A - Found in the Discord

What this PR solves / how to test: Pages dev previously forced people to use local mode, however this got broken somewhere in the past. This pull fixes it, and prevents people from using remote mode once again

TLDR; Force local was incorrectly put in the startApiDev version of unstable_dev instead of the one that Pages uses

Associated docs issue(s)/PR(s):

  • N/A

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@Skye-31 Skye-31 requested a review from a team as a code owner March 21, 2023 11:39
@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023

🦋 Changeset detected

Latest commit: b31f3e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4478574838/npm-package-wrangler-2931

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2931/npm-package-wrangler-2931

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4478574838/npm-package-wrangler-2931 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4478574838/npm-package-cloudflare-pages-shared-2931

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #2931 (b31f3e8) into main (2496a42) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
+ Coverage   74.05%   74.08%   +0.02%     
==========================================
  Files         167      167              
  Lines       10419    10419              
  Branches     2786     2786              
==========================================
+ Hits         7716     7719       +3     
+ Misses       2703     2700       -3     
Impacted Files Coverage Δ
packages/wrangler/src/api/dev.ts 60.21% <ø> (ø)

... and 2 files with indirect coverage changes

@WalshyDev WalshyDev merged commit 5f6c4c0 into cloudflare:main Mar 21, 2023
@WalshyDev WalshyDev deleted the skye/pages-local-mode branch March 21, 2023 12:06
@github-actions github-actions bot mentioned this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants