Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[surfacer.postgres] Switch to newer pgx postgres driver #305

Merged
merged 4 commits into from May 13, 2024
Merged

[surfacer.postgres] Switch to newer pgx postgres driver #305

merged 4 commits into from May 13, 2024

Conversation

manugarg
Copy link
Contributor

@manugarg manugarg commented Mar 2, 2023

No description provided.

@manugarg manugarg mentioned this pull request Mar 3, 2023
Closed
@manugarg manugarg marked this pull request as draft March 3, 2023 18:59
@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@markoposavec
Copy link
Contributor

Hey!
Is there a plan of merging this?
pgx postgres driver allows setting multiple hosts in connection string which would solve some issues for us 😄

@manugarg
Copy link
Contributor Author

Sorry for leaving it without a comment. I didn't merge this because new driver doubles the size of the binary. I'll take another look at it.

@manugarg manugarg marked this pull request as ready for review May 10, 2024 23:59
@manugarg
Copy link
Contributor Author

Sorry for leaving it without a comment. I didn't merge this because new driver doubles the size of the binary. I'll take another look at it.

Binary size increase is only about 8% now. Given the benefits of pgx driver over lib/pq, I'll try merge it soon.

@manugarg
Add tests for DB rows creation and use float64 for values instead of …
0f4769f 
…strings.
@manugarg
There is no point in using floa64 for values. They get converted to s…
16a54d3 
…trings

by the database driver anyway.

For CopyFrom, db driver simply writes values to the stdout (pipe).
@manugarg manugarg merged commit d4bfee7 into master May 13, 2024
8 of 9 checks passed
@manugarg manugarg deleted the postgres branch May 13, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manugarg @markoposavec