Introducing `DIGInoHLT` + `HLTOnly` Steps #44964

AdrianoDee · 2024-05-13T15:15:33Z

PR description:

This PR proposes the introduction of a set of workflows where HLT is run separately from the DIGI step. This expands the *.601 wf approach allowing to have any 2024 wf, also the special ones. For the moment it's limited to 2024 (with 2024HLTOnDigi and 2024HLTOnDigiPU) but could be expanded further. From our (PdmV) point of view it would ease the submission of reHLT wfs with the RelVal machine.

An example here for 15834.0.

# in: /lustre/home/adrianodif/random_devs/PR_ReHLT/cmssw/src dryRun for 'cd 15834.0_TTbar_14TeV+2024HLTOnDigiPU
 cmsDriver.py TTbar_14TeV_TuneCP5_cfi  -s GEN,SIM -n 10 --conditions auto:phase1_2024_realistic --beamspot DBrealistic --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry DB:Extended --era Run3 --relval 9000,100 --fileout file:step1.root  > step1_TTbar_14TeV+2024DigiAndHLTPU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_ReHLT/cmssw/src dryRun for 'cd 15834.0_TTbar_14TeV+ 2024HLTOnDigiPU
 cmsDriver.py step2  -s DIGI:pdigi_valid,L1,DIGI2RAW --conditions auto:phase1_2024_realistic --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry DB:Extended --era Run3 --pileup Run3_Flat55To75_PoissonOOTPU --pileup_input das:/RelValMinBias_14TeV/1/GEN-SIM --filein  file:step1.root  --fileout file:step2.root  > step2_TTbar_14TeV+2024DigiAndHLTPU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_ReHLT/cmssw/src dryRun for 'cd 15834.0_TTbar_14TeV+ 2024HLTOnDigiPU
 cmsDriver.py step3  -s HLT:@relval2024 --conditions auto:phase1_2024_realistic --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry DB:Extended --era Run3 --filein  file:step2.root  --fileout file:step3.root  > step3_TTbar_14TeV+2024DigiAndHLTPU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_ReHLT/cmssw/src dryRun for 'cd 15834.0_TTbar_14TeV+ 2024HLTOnDigiPU
 cmsDriver.py step4  -s RAW2DIGI,L1Reco,RECO,RECOSIM,PAT,NANO,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2024_realistic --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 10 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3 --pileup Run3_Flat55To75_PoissonOOTPU --pileup_input das:/RelValMinBias_14TeV/1/GEN-SIM --filein  file:step3.root  --fileout file:step4.root  > step4_TTbar_14TeV+2024DigiAndHLTPU.log  2>&1
 

# in: /lustre/home/adrianodif/random_devs/PR_ReHLT/cmssw/src dryRun for 'cd 15834.0_TTbar_14TeV+ 2024HLTOnDigiPU
 cmsDriver.py step5  -s HARVESTING:@standardValidation+@standardDQM+@ExtraHLT+@miniAODValidation+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2024_realistic --mc  --geometry DB:Extended --scenario pp --filetype DQM --era Run3 -n 10 --pileup Run3_Flat55To75_PoissonOOTPU --pileup_input das:/RelValMinBias_14TeV/1/GEN-SIM --filein file:step4_inDQM.root --fileout file:step5.root  > step5_TTbar_14TeV+2024DigiAndHLTPU.log  2>&1

PR validation:

Running, e.g., 15624.701 15834.0 and 15834.402 wfs.

cmsbuild · 2024-05-13T15:16:01Z

cms-bot internal usage

cmsbuild · 2024-05-13T15:22:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44964/40237

This PR adds an extra 76KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Fix relval embedding workflows #44928, change input siPixelClusters collection for 1040.0 wf step2 #44932
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761, Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964, introducing BigPixel for phase-2 InnerTracker in T39 geometry #44576, first release of TICLv5 #44785

cmsbuild · 2024-05-13T15:22:34Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@subirsarkar, @sunilUIET, @miquork, @AdrianoDee, @srimanob, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @makortel, @fabiocos, @slomeo, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2024-05-13T15:24:22Z

test parameters:

workflows=15624.701,15834.0,15834.402

AdrianoDee · 2024-05-13T15:24:59Z

please test

cmsbuild · 2024-05-13T17:09:18Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee050a/39362/summary.html
COMMIT: d60286d
CMSSW: CMSSW_14_1_X_2024-05-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44964/39362/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 15624.701, 15834.402, 15834.0

AdrianoDee · 2024-05-14T05:59:11Z

test parameters:

workflows=15624.701,15834.0,15834.402
workflow_opts = -w upgrade

AdrianoDee · 2024-05-14T05:59:15Z

please test

AdrianoDee · 2024-05-14T06:04:55Z

please test

cmsbuild · 2024-05-14T07:48:38Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee050a/39370/summary.html
COMMIT: d60286d
CMSSW: CMSSW_14_1_X_2024-05-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44964/39370/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

15834.0

----- Begin Fatal Exception 14-May-2024 09:32:13 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

15834.402

----- Begin Fatal Exception 14-May-2024 09:32:25 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

cmsbuild · 2024-05-15T18:32:04Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee050a/39388/summary.html
COMMIT: e09d97f
CMSSW: CMSSW_14_1_X_2024-05-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44964/39388/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

4.584.58_WElSkim2012B/step2_WElSkim2012B.log
4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338976
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338953
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

AdrianoDee · 2024-05-16T12:28:23Z

please test

cmsbuild · 2024-05-16T15:49:33Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee050a/39408/summary.html
COMMIT: e09d97f
CMSSW: CMSSW_14_1_X_2024-05-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44964/39408/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338976
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338953
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

AdrianoDee · 2024-05-16T15:54:31Z

+pdmv
(new workflows went smoothly)

srimanob · 2024-05-22T18:37:15Z

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

@@ -36,6 +36,9 @@
    '2022HIRP', #RawPrime
    '2023HI',
    '2023HIRP', #RawPrime
+    '2024HLTOnDigi',
+    '2024HLTOnDigiPU'
+


Do we need space here? Maybe it can be fixed later when new workflow comes.

Not really, right. Let me fix it in one of the other PRs I have or will open on upgrade wfs.

srimanob · 2024-05-22T18:37:56Z

+Upgrade

cmsbuild · 2024-05-22T18:38:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-05-23T17:08:39Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone May 13, 2024

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels May 13, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 13, 2024

cmsbuild added tests-started and removed tests-pending labels May 13, 2024

cmsbuild mentioned this pull request May 13, 2024

Add D110 Default Input Dataset #44965

Open

cmsbuild added tests-rejected and removed tests-started labels May 13, 2024

cmsbuild added tests-started and removed tests-rejected labels May 14, 2024

cmsbuild added tests-rejected and removed tests-started labels May 14, 2024

Introducing DIGI with noHLT + HLTOnly steps

e09d97f

AdrianoDee force-pushed the reHLT_wfs branch from d60286d to e09d97f Compare May 14, 2024 11:12

cmsbuild added the tests-started label May 15, 2024

cmsbuild added tests-rejected and removed tests-started labels May 15, 2024

cmsbuild added tests-started and removed tests-rejected labels May 16, 2024

cmsbuild added tests-approved and removed tests-started labels May 16, 2024

cmsbuild added pdmv-approved and removed pdmv-pending labels May 16, 2024

This was referenced May 21, 2024

Introducing SimOnGen and GenOnly wfs for 2024 and 2026D110 #45005

Open

add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761

Open

srimanob reviewed May 22, 2024

View reviewed changes

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels May 22, 2024

cmsbuild mentioned this pull request May 22, 2024

Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910

Open

cmsbuild added orp-approved and removed orp-pending labels May 23, 2024

cmsbuild merged commit 0c72f65 into cms-sw:master May 23, 2024
12 checks passed

This was referenced May 24, 2024

clang-tidy: Remove deprecated AnalyzeTemporaryDtors option #45034

Merged

[llvm] Update to version 18.1.6 cms-sw/cmsdist#9200

Open

AdrianoDee deleted the reHLT_wfs branch May 28, 2024 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing `DIGInoHLT` + `HLTOnly` Steps #44964

Introducing `DIGInoHLT` + `HLTOnly` Steps #44964

AdrianoDee commented May 13, 2024

cmsbuild commented May 13, 2024 •

edited

cmsbuild commented May 13, 2024

cmsbuild commented May 13, 2024

AdrianoDee commented May 13, 2024

AdrianoDee commented May 13, 2024

cmsbuild commented May 13, 2024

AdrianoDee commented May 14, 2024

AdrianoDee commented May 14, 2024

AdrianoDee commented May 14, 2024

cmsbuild commented May 14, 2024

cmsbuild commented May 15, 2024

AdrianoDee commented May 16, 2024

cmsbuild commented May 16, 2024

AdrianoDee commented May 16, 2024

srimanob May 22, 2024

AdrianoDee May 22, 2024

srimanob commented May 22, 2024

cmsbuild commented May 22, 2024

antoniovilela commented May 23, 2024

Introducing DIGInoHLT + HLTOnly Steps #44964

Introducing DIGInoHLT + HLTOnly Steps #44964

Conversation

AdrianoDee commented May 13, 2024

PR description:

PR validation:

cmsbuild commented May 13, 2024 • edited

cmsbuild commented May 13, 2024

cmsbuild commented May 13, 2024

AdrianoDee commented May 13, 2024

AdrianoDee commented May 13, 2024

cmsbuild commented May 13, 2024

RelVals

AdrianoDee commented May 14, 2024

AdrianoDee commented May 14, 2024

AdrianoDee commented May 14, 2024

cmsbuild commented May 14, 2024

RelVals

cmsbuild commented May 15, 2024

RelVals-INPUT

Comparison Summary

AdrianoDee commented May 16, 2024

cmsbuild commented May 16, 2024

Comparison Summary

AdrianoDee commented May 16, 2024

srimanob May 22, 2024

Choose a reason for hiding this comment

AdrianoDee May 22, 2024

Choose a reason for hiding this comment

srimanob commented May 22, 2024

cmsbuild commented May 22, 2024

antoniovilela commented May 23, 2024

Introducing `DIGInoHLT` + `HLTOnly` Steps #44964

Introducing `DIGInoHLT` + `HLTOnly` Steps #44964

cmsbuild commented May 13, 2024 •

edited