Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide clarity on future of tokenless uploads from GitHub Actions #1293

Open
lpsinger opened this issue Feb 14, 2024 · 3 comments
Open

Provide clarity on future of tokenless uploads from GitHub Actions #1293

lpsinger opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@lpsinger
Copy link

v4 dropped support for tokenless uploads on GitHub Actions due to #1068 ("use cli instead of node uploader"). In the PR description there is the comment:

Notes to reviewer:

  • Currently tokenless upload is not supported. Releasing this PR for users who are not using a codecov token will break their CI

Is there a plan to restore support for tokenless uploads in the the GitHub Action going forward? Tokenless uploads still work with v3, the Node uploader obviously still supports tokenless uploads. Will the CLI uploader gain support for them? The Codecov documentation still mentions tokenless uploads in lots of places.

@louwers
Copy link

louwers commented Feb 21, 2024

Despite mentioning "PRs made from forks to the upstream public repos will support tokenless" in the changelog, this does not seem to be working at all.

yuxincs added a commit to uber/NullAway that referenced this issue Feb 23, 2024
We have upgraded our codecov upload action to v4. However, tokenless
uploads are unsupported now (see
codecov/codecov-action#1293). This PR fixes
the config to give the action a codecov token stored in repository
secrets.
dtrifiro added a commit to dtrifiro/caikit-nlp-client that referenced this issue Feb 26, 2024
dtrifiro added a commit to opendatahub-io/caikit-nlp-client that referenced this issue Feb 26, 2024
takluyver added a commit to takluyver/astsearch that referenced this issue Feb 27, 2024
New codecov action breaks tokenless uploads for vague reason
codecov/codecov-action#1293

This reverts commit ccd193c.
@thomasrockhu-codecov thomasrockhu-codecov removed their assignment Mar 14, 2024
JoshuaKGoldberg added a commit to JoshuaKGoldberg/create-typescript-app that referenced this issue Mar 30, 2024
## PR Checklist

- [x] Addresses an existing open issue: fixes #1435
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Altogether stops repositories from being upgraded to
`codecov/codev-action@v4`.

This can always be revisited if & when Codecov provides more details on
tokenless uploads
(codecov/codecov-action#1293).
justinchuby added a commit to microsoft/onnxscript that referenced this issue Apr 1, 2024
Codecov actions v4 requires CODECOV_TOKEN to be provided codecov/codecov-action#1293
justinchuby added a commit to microsoft/onnxscript that referenced this issue Apr 1, 2024
Codecov actions v4 requires CODECOV_TOKEN to be provided
codecov/codecov-action#1293
@elBoberido
Copy link

Would be great to get some feedback on this. Are tokens now a hard requirement?

We just updated from v3 to v4 and the upload is broken.

jeanregisser added a commit to valora-inc/viem-account-hsm-gcp that referenced this issue Apr 19, 2024
Ah the token is now needed with `codecov/codecov-action@v4`

codecov/codecov-action#1293
@lpsinger
Copy link
Author

lpsinger commented May 3, 2024

My projects that use codecov are now saying:

[2024-05-03T23:11:57.452Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 10 seconds.', code='throttled')}

Is tokenless uploading gone for good now? It would be really helpful to get confirmation from someone at Codecov on this.

@thomasrockhu-codecov thomasrockhu-codecov added the documentation Improvements or additions to documentation label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants