ref: Move useRepoConfig off RepositoryDeprecated #2860
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2860 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 875 875
Lines 12914 12927 +13
Branches 3397 3461 +64
=======================================
+ Hits 12718 12731 +13
Misses 192 192
Partials 4 4
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2860 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 875 875
Lines 12914 12927 +13
Branches 3462 3461 -1
=======================================
+ Hits 12718 12731 +13
Misses 192 192
Partials 4 4
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2860 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 875 875
Lines 12914 12927 +13
Branches 3396 3443 +47
=======================================
+ Hits 12718 12731 +13
Misses 192 192
Partials 4 4
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2860 +/- ##
=====================================
Coverage 98.48 98.48
=====================================
Files 875 875
Lines 12914 12927 +13
Branches 3457 3443 -14
=====================================
+ Hits 12718 12731 +13
Misses 192 192
Partials 4 4
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 6.67kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 6.67kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| // silence console errors | ||
| console.error = () => {} |
There was a problem hiding this comment.
Can you move this into only tests that we expect things to log out in, that way incase a test fails that we don't expect we will be able to see the log and why it was failing and make it a bit easier to clean up.
There was a problem hiding this comment.
Yeah that's fair, made the change in 694d902
ajay-sentry
force-pushed
the
Ajay/convert-use-repo-config
branch
from
a79f14b
to
694d902
Compare
Description
moves useRepoConfig off repositoryDeprecated, adds UT's and updates other UT's
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.