Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add importlib-metadata dependency #115

Closed
wants to merge 6 commits into from

Conversation

johnflavin
Copy link

@johnflavin johnflavin commented Jan 19, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #114

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks John! 😄

Had one small suggestion below

script: {{ PYTHON }} -m pip install . -vv
entry_points:
- sphinx-build = sphinx.cmd.build:main
- sphinx-quickstart = sphinx.cmd.quickstart:main
- sphinx-apidoc = sphinx.ext.apidoc:main
- sphinx-autogen = sphinx.ext.autosummary.generate:main
skip: true # [py<36]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we don't build for anything older than Python 3.6, this can be dropped

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skip: true # [py<36]

@bollwyvl
Copy link
Contributor

/Users/runner/miniforge3/conda-bld/sphinx_1642628795584/work/conda_build.sh: line 4: /Users/runner/miniforge3/conda-bld/sphinx_1642628795584/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/bin/python: Bad CPU type in executable

That ickiness aside, dropping noarch seems like a heavy price to pay... i've opened #116 as an alternative. it appears they are just using the entry_points reader. it won't be strictly accurate, but also won't fail, either...

- alabaster >=0.7,<0.8
- babel >=1.3
- docutils >=0.14,<0.18
- imagesize
- importlib-metadata >=4.4 # [py<310]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note, this replaces setuptools, so that can be removed below... c/f sphinx-doc/sphinx#10007

@johnflavin
Copy link
Author

dropping noarch seems like a heavy price to pay

I agree. I'm not really a fan of dropping noarch and adding a lot more complexity to the build. Which, incidentally, is failing at the moment because I don't have a good grasp of all the build configurations that need to be set. (Clearly the configurations I yoinked from matplotlib's feedstock aren't all working.) Plus there isn't even a build for 3.10, which I would have expected.

I'm going to close this for now in favor of #116.

@johnflavin johnflavin closed this Jan 20, 2022
@jakirkham
Copy link
Member

Thanks for working on this John! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need dependency on importlib-metadata
4 participants