New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add importlib-metadata dependency #115
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
…d for non-supported python versions.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2022.01.18.20.31.32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks John! 😄
Had one small suggestion below
script: {{ PYTHON }} -m pip install . -vv | ||
entry_points: | ||
- sphinx-build = sphinx.cmd.build:main | ||
- sphinx-quickstart = sphinx.cmd.quickstart:main | ||
- sphinx-apidoc = sphinx.ext.apidoc:main | ||
- sphinx-autogen = sphinx.ext.autosummary.generate:main | ||
skip: true # [py<36] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we don't build for anything older than Python 3.6, this can be dropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip: true # [py<36] |
That ickiness aside, dropping noarch seems like a heavy price to pay... i've opened #116 as an alternative. it appears they are just using the |
- alabaster >=0.7,<0.8 | ||
- babel >=1.3 | ||
- docutils >=0.14,<0.18 | ||
- imagesize | ||
- importlib-metadata >=4.4 # [py<310] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note, this replaces setuptools
, so that can be removed below... c/f sphinx-doc/sphinx#10007
I agree. I'm not really a fan of dropping I'm going to close this for now in favor of #116. |
Thanks for working on this John! 😄 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes #114