New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add importlib-metadata, https URLs, remove setuptools #116
add importlib-metadata, https URLs, remove setuptools #116
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nick! 😄
Had a few questions below. Also does this need a build number bump?
@@ -29,6 +29,7 @@ requirements: | |||
- babel >=1.3 | |||
- docutils >=0.14,<0.18 | |||
- imagesize | |||
- importlib-metadata >=4.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have importlib-metadata
on Python 3.10+? What happens when it is installed there? How does this interact with the builtin importlib.metadata
when available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have importlib-metadata on Python 3.10+? W
We do, back to e.g. linux-64/importlib-metadata-4.8.1-py310hff52083_1.tar.bz2
What happens when it is installed there
Nothing too freaky... it doesn't shadow the builtin (importlib.resources
) or anything.
interact with the builtin importlib.metadata when available?
In the cases I've found, it looks like it will preferentially import from the separate package before trying the builtin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting would have thought the builtin would be tried first. Have asked about that ( sphinx-doc/sphinx#10007 (review) ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it was answered... again, it's highly likely some package in a good-sized sphinx env is going to have the latest-and-greatest importlib because a lot of authors (pragmatically) can't be bothered to do pins, and i don't blame them. if it can't deal with the backport, then there are bigger problems, and if python keeps changing the API, this problem will basically never go away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep agreed. Am use to seeing the other import
order as the backport package is pretty static and eventually fades out of existence. There are of course exceptions like mock
. Seems like this is more like mock
than other backport packages.
If things become more fragmented, like the backport package should be used for certain Python versions and not others, we may need revisit dropping noarch
.
Though hopefully things settle down eventually.
@conda-forge-admin please rerender |
…nda-forge-pinning 2022.01.18.20.31.32
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Notes:
Fixes #114