Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add importlib-metadata, https URLs, remove setuptools #116

Merged
merged 3 commits into from Jan 20, 2022

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 19, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Notes:

Fixes #114

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl bollwyvl mentioned this pull request Jan 19, 2022
5 tasks
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick! 😄

Had a few questions below. Also does this need a build number bump?

@@ -29,6 +29,7 @@ requirements:
- babel >=1.3
- docutils >=0.14,<0.18
- imagesize
- importlib-metadata >=4.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have importlib-metadata on Python 3.10+? What happens when it is installed there? How does this interact with the builtin importlib.metadata when available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have importlib-metadata on Python 3.10+? W

We do, back to e.g. linux-64/importlib-metadata-4.8.1-py310hff52083_1.tar.bz2

What happens when it is installed there

Nothing too freaky... it doesn't shadow the builtin (importlib.resources) or anything.

interact with the builtin importlib.metadata when available?

In the cases I've found, it looks like it will preferentially import from the separate package before trying the builtin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting would have thought the builtin would be tried first. Have asked about that ( sphinx-doc/sphinx#10007 (review) ).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was answered... again, it's highly likely some package in a good-sized sphinx env is going to have the latest-and-greatest importlib because a lot of authors (pragmatically) can't be bothered to do pins, and i don't blame them. if it can't deal with the backport, then there are bigger problems, and if python keeps changing the API, this problem will basically never go away.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep agreed. Am use to seeing the other import order as the backport package is pretty static and eventually fades out of existence. There are of course exceptions like mock. Seems like this is more like mock than other backport packages.

If things become more fragmented, like the backport package should be used for certain Python versions and not others, we may need revisit dropping noarch.

Though hopefully things settle down eventually.

recipe/meta.yaml Show resolved Hide resolved
@bollwyvl
Copy link
Contributor Author

@conda-forge-admin please rerender

@bollwyvl bollwyvl changed the title add importlib-metadata, https URLs add importlib-metadata, https URLs, remove setuptools Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need dependency on importlib-metadata
3 participants