Remove a manual layerStore.Touch() call from store.Shutdown() #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
None that I know of. |
mtrmac
force-pushed
the
shutdown-touch
branch
2 times, most recently
from
05d7c91
to
a581260
Compare
It's completely unclear why this is necessary; the unmount calls actually write to the separate mountpoints.json file, with a separate lock. When this was originally introduced in b046fb5 , there wasn't a separate mountpoints.json file, and store.go was manually calling Touch() everywhere; so my best guess is that this is just an artifact of making those two API changes, and the Touch() is not actually necessary. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
shutdown-touch
branch
from
a581260
to
0b5faf9
Compare
|
That does look like a relic from the past. Removing it LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's completely unclear to me why this is necessary; the unmount calls actually write to the separate mountpoints.json file, with a separate lock.
When this was originally introduced in b046fb5 , there wasn't a separate
mountpoints.jsonfile (changed in 0183a29 ), and store.go was manually callingTouch()everywhere (changed in c496eac) ; so my best guess is that this is just an artifact of making those two API changes, and theTouch()is not actually necessary.@nalind @rhatdan is there some non-obvious purpose for the
Touch()call here?