Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a manual layerStore.Touch() call from store.Shutdown() #1381

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Remove a manual layerStore.Touch() call from store.Shutdown() #1381

merged 1 commit into from
Oct 14, 2022

Commits on Oct 14, 2022

  1. Remove a manual layerStore.Touch() call from store.Shutdown() 

    It's completely unclear why this is necessary; the unmount calls
actually write to the separate mountpoints.json file, with a separate lock.

When this was originally introduced in b046fb5 ,
there wasn't a separate mountpoints.json file, and store.go was manually
calling Touch() everywhere; so my best guess is that this is just an
artifact of making those two API changes, and the Touch() is not actually
necessary.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac
    mtrmac committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    0b5faf9 View commit details
    Browse the repository at this point in the history