container deletion - EBUSY improvement #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return early instead of having a large body in nested branches. Preserve the logic of returning ErrNotAContainer even on Get(). Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Most likely just a cosmetic change. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
The function is being used in a number of places, notably container removal and cleanup. While container removal already loops over EBUSY, cleanup does not. To make sure that all callers of Unmount get a fair chance of unmounting cleanly, also loop there. I used the same values as containerd: 50 loops with 50ms sleeps. Context: containers/podman/issues/11594 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
rhatdan
changed the title
|
LGTM |
mtrmac
reviewed
Oct 18, 2022
| // assumes that the flags value is always correct. | ||
| return nil | ||
| default: | ||
| break |
There was a problem hiding this comment.
From staticcheck as run by VS Code:
ineffective break statement. Did you mean to break out of the outer loop? (SA4011)
There was a problem hiding this comment.
Thanks for spotting and reporting!
I keep forgetting the break semantics. Opened #1401 to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of beatifications along with a change in hope to improve on containers/podman/issues/11594. Please refer to the individual commits.
@giuseppe @nalind @rhatdan WDYT?