Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container deletion - EBUSY improvement #1382

Merged
merged 3 commits into from
Oct 13, 2022
Merged

container deletion - EBUSY improvement #1382

merged 3 commits into from
Oct 13, 2022

Commits on Oct 13, 2022

  1. DeleteContainer: simplify logic 

    Return early instead of having a large body in nested branches.
Preserve the logic of returning ErrNotAContainer even on Get().

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
    @vrothberg
    vrothberg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    0a7dd54 View commit details
    Browse the repository at this point in the history

  2. EnsureRemoveAll: use IsEBUSY 

    Most likely just a cosmetic change.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
    @vrothberg
    vrothberg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    92a2cec View commit details
    Browse the repository at this point in the history

  3. mount.Umount: EBUSY: try at most 50 times 

    The function is being used in a number of places, notably container
removal and cleanup.  While container removal already loops over EBUSY,
cleanup does not.

To make sure that all callers of Unmount get a fair chance of unmounting
cleanly, also loop there.  I used the same values as containerd: 50
loops with 50ms sleeps.

Context: containers/podman/issues/11594
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
    @vrothberg
    vrothberg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    d885bfb View commit details
    Browse the repository at this point in the history