Consolidate the common parts of simple writers #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
#1384 is a counterpart for the more complex read paths. |
... to avoid the repetition of getting, locking,
and reloading, the store.
Use it at least for the simplest writers.
This could be more elegant with Go generics, returning
(T, error), with T possibly being void = struct{}.
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to avoid the repetition of getting, locking,
and reloading, the store.
Use it at least for the simplest writers.
This could be more elegant with Go generic returning
(T, error), with T possibly being void = struct{}.
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to avoid the repetition of getting, locking,
and reloading, the store.
Use it at least for the simplest writers.
This could be more elegant with Go generics, returning
(T, error), with T possibly being void = struct{}.
Should not change behavior.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to avoid the repetition of getting, locking, and reloading, the stores. This also makes it less error-prone to use a consistent locking order (but note that other instances of manual locking still exist). Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
simple-writers
branch
from
66f31da
to
cae12e3
Compare
vrothberg
approved these changes
Oct 14, 2022
| // writeToLayerStore is a helper for working with store.getLayerStore(): | ||
| // It locks the store for writing, checks for updates, and calls fn() | ||
| // It returns the return value of fn, or its own error initializing the store. | ||
| func (s *store) writeToLayerStore(fn func(store rwLayerStore) error) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out the repetitive “find and lock C/I/L store” parts out of the top-level
storage.StoreAPI into helpers:writeTo{Container,Image,Layer}StoreandwriteToAllStores.Overall, this is just a refactoring that should not change behavior. The goal is to decrease the number of individual call sites to the locking code — so that the code refactored here does not need to be touched again for locking changes.
The more complex writers that don’t fit the simple locking schemes of these helpers remain unchanged; the locking in them will be updated individually.
See individual commit messages for (a bit) more detail. It might be more convenient to review this in a view that ignores whitespace changes.