Use unix.Open instead of os.OpenFile for /dev/zfs #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a bash error message: .../test/helpers.bash: line 10: [: : integer expression expected Signed-off-by: Doug Rabson <dfr@rabson.org>
The alternative os.OpenFile internally tries to enable non-blocking i/o on the descriptor which on FreeBSD has the side effect of printing a cryptic error message on the console (openzfs/zfs#14286). Signed-off-by: Doug Rabson <dfr@rabson.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is testing that its possible to open the /dev/zfs device. Using os.OpenFile does other things to the open file, including trying to set non-blocking i/o which triggers a cryptic error message on the console on FreeBSD.
I plan to fix that upstream in openzfs (openzfs/zfs#14286) but in the meantime, using unix.Open instead of os.OpenFile avoids the problem.