Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unix.Open instead of os.OpenFile for /dev/zfs #1450

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Use unix.Open instead of os.OpenFile for /dev/zfs #1450

merged 2 commits into from
Dec 13, 2022

Commits on Dec 13, 2022

  1. tests: Add a better default value for STORAGE_TRANSIENT 

    This was causing a bash error message:

	.../test/helpers.bash: line 10: [: : integer expression expected

Signed-off-by: Doug Rabson <dfr@rabson.org>
    @dfr
    dfr committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    6b3865c View commit details
    Browse the repository at this point in the history

  2. zfs: Use unix.Open to verify that /dev/zfs exists 

    The alternative os.OpenFile internally tries to enable non-blocking i/o
on the descriptor which on FreeBSD has the side effect of printing a
cryptic error message on the console
(openzfs/zfs#14286).

Signed-off-by: Doug Rabson <dfr@rabson.org>
    @dfr
    dfr committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    aeed7a1 View commit details
    Browse the repository at this point in the history