Bump postcss-values-replace #941
Conversation
SkReD
force-pushed
the
bump-postcss-values-replace
branch
from
8004607
to
29936e6
Compare
| if (u[0] === '.') { | ||
| u = u.slice(1); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why removing the leading . ?
There was a problem hiding this comment.
my thought is that it is not the part of unit but the value
There was a problem hiding this comment.
for input like https://github.com/TrySound/postcss-value-parser/blob/master/test/unit.js#L10, there would be still number (length) in the unit.
I wonder whether this should be fixed in postcss-value-parser as .3rem or 3rem is even a value unit or not.
There was a problem hiding this comment.
Yes, it is not good idea
There was a problem hiding this comment.
@SkReD can you undo this change and we can submit a issue in the parser repo as this should be handled by the parser not by the minifier
SkReD
force-pushed
the
bump-postcss-values-replace
branch
from
29936e6
to
92c434d
Compare
| if (u[0] === '.') { | ||
| u = u.slice(1); | ||
| } | ||
|
|
There was a problem hiding this comment.
for input like https://github.com/TrySound/postcss-value-parser/blob/master/test/unit.js#L10, there would be still number (length) in the unit.
I wonder whether this should be fixed in postcss-value-parser as .3rem or 3rem is even a value unit or not.
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 120 120
Lines 3499 3501 +2
Branches 1057 1058 +1
=======================================
+ Hits 3412 3414 +2
Misses 80 80
Partials 7 7
Continue to review full report at Codecov.
|
SkReD
force-pushed
the
bump-postcss-values-replace
branch
from
5d98f96
to
5ad05d2
Compare
|
|
|
Fixed in 5.0.0. I've added the commit with the test case to #1059 |
Closes #909