Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCK: Add implementation of named hook in ruby #1984

Merged
merged 4 commits into from
May 18, 2022
Merged

CCK: Add implementation of named hook in ruby #1984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e00ffc2
Add implementation of named hook in the ruby CCK
aurelien-reeves May 18, 2022
48e7706
Add link to the PR in the changelog
aurelien-reeves May 18, 2022
d87ebcf
Exclude hooks from json-formatter acceptance tests
aurelien-reeves May 18, 2022
25099e9
Use a version of cucumber which actually supports named hooks. This s…
aurelien-reeves May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions compatibility-kit/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Fixed

* [Ruby] Add implementation for named hooks ([#1984](https://github.com/cucumber/common/pull/1984))

## [9.2.0] - 2022-04-01

### Added
Expand Down
3 changes: 1 addition & 2 deletions compatibility-kit/ruby/features/hooks/hooks.feature.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ def attach_or_embed(world, data, media_type)
# no-op
end

Before do
# This is the equivalent of the new named hook in typescript
Before(name: 'A named hook') do
# no-op
end

Expand Down
2 changes: 1 addition & 1 deletion json-formatter/ruby-testdata/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }

gem "cucumber", "~> 7.1.0"
gem "cucumber", git: 'https://github.com/cucumber/cucumber-ruby.git', branch: 'add-support-for-named-hooks'
gem "json"
gem "rspec"