Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCK: Add implementation of named hook in ruby #1984

Merged
merged 4 commits into from May 18, 2022

Conversation

aurelien-reeves
Copy link
Contributor

Summary

About to release cucumber-ruby 8.0.0.
After upgrading all the gems, cucumber-ruby does not pass the CCK due to missing named hooks support.
It is actually pretty easy to add, so, let's add it in the CCK first, then on cucumber-ruby.

Here, we just need to add a name to the "Before" hook in the ruby step definitions

Named hooks are not supported yet by the version of cucumber-ruby used
in the validation tests of the json-formatter
Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me again of the reasoning behind / how we mean to use this.

It's fine the implementation. I just can't remember the why

@aurelien-reeves
Copy link
Contributor Author

Remind me again of the reasoning behind / how we mean to use this.

It's fine the implementation. I just can't remember the why

Why ... what? The named hooks?

If so, they have been added to cucumber-js recently: cucumber/cucumber-js#1994

I think it is a nice addition, and pretty easy to add to cucumber-ruby.
I think the html-formatter is already aware of those named hooks too.

But if any objection, I can wait and let this opened for discussion :)

@luke-hill
Copy link
Contributor

No no it's fine. I just couldn't remember the discussion / why. Definitely not against this.

@aurelien-reeves
Copy link
Contributor Author

TBH there have not been any discussion regarding supporting those named hooks in cucumber-ruby. I was about to release cucumber-ruby, and noticed a cck failed test after upgrading the gems (gherkin, messages, the cck). So I worked on adding that support in cucumber-ruby

But of course, that would have passed through a PR, then the discussion would have started there :)

@aurelien-reeves aurelien-reeves merged commit cf9e64e into main May 18, 2022
@aurelien-reeves aurelien-reeves deleted the cck-ruby-add-named-hooks branch May 18, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants