Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Windows build on CircleCI #49

Merged
merged 26 commits into from
Dec 27, 2019
Merged

Test Windows build on CircleCI #49

merged 26 commits into from
Dec 27, 2019

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Aug 27, 2019

@bahmutov bahmutov mentioned this pull request Aug 27, 2019
5 tasks
@bahmutov bahmutov requested a review from flotwig November 5, 2019 15:57
@flotwig
Copy link
Contributor

flotwig commented Dec 26, 2019

@bahmutov This is unblocked now that Cypress can run in Windows CircleCI, right?

@flotwig flotwig removed their request for review December 26, 2019 18:06
@bahmutov
Copy link
Contributor Author

bahmutov commented Dec 26, 2019 via email

@flotwig
Copy link
Contributor

flotwig commented Dec 26, 2019

Not passing yet, but it seems to be a failure in copying artifacts, not in Cypress itself

@bahmutov
Copy link
Contributor Author

bahmutov commented Dec 26, 2019 via email

@bahmutov
Copy link
Contributor Author

bahmutov commented Dec 26, 2019

@flotwig I have updated the dependency ok-file that was checking files - it was getting single-quoted argument on Windows, breaking it. Now Circle is happy again and AppVeyor failures are because it is AppVeyor and fails sometimes to pass env variables!

Literally this is stupid https://ci.appveyor.com/project/cypress-io/cypress-test-tiny-fitqm/builds/29766710

node_modules\.bin\run-if npm run cypress:verify
Platform win32 is allowed
Arch ia32 is allowed
> cypress-test-tiny@1.0.0 cypress:verify C:\projects\cypress-test-tiny-fitqm
> cypress verify
[21:21:54]  Verifying Cypress can run C:\Users\appveyor\AppData\Local\Cypress\Cache\3.8.1\Cypress [started]
[21:21:56]  Verifying Cypress can run C:\Users\appveyor\AppData\Local\Cypress\Cache\3.8.1\Cypress [completed]
node_modules\.bin\run-if npm run cypress:run -- --record
Platform win32 is allowed
Arch ia32 is allowed
> cypress-test-tiny@1.0.0 cypress:run C:\projects\cypress-test-tiny-fitqm
> cypress run "--record"
You passed the --record flag but this project has not been setup to record.
This project is missing the 'projectId' inside of 'cypress.json'.
We cannot uniquely identify this project without this id.
You need to setup this project to record. This will generate a unique 'projectId'.
Alternatively if you omit the --record flag this project will run without recording.
https://on.cypress.io/recording-project-runs
npm ERR! code ELIFECYCLE
npm ERR! errno 1

The record key and project id are set as environment variables on AppVeyor for this project.

@flotwig
Copy link
Contributor

flotwig commented Dec 26, 2019

Appveyor has been failing since 2f2b827 in this branch with the same error, also, that job doesn't seem to exist for any of the commits before that 2f2b827. I looked at the changes but don't really understand how they could be causing Appveyor to run when it didn't before.

@bahmutov
Copy link
Contributor Author

ok, I removed recording on AppVeyor, enough is enough

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

package.json Outdated Show resolved Hide resolved
Co-Authored-By: Zach Bloomquist <github@chary.us>
@bahmutov
Copy link
Contributor Author

yeah, it is ok to remove hardcoded version

@flotwig flotwig merged commit 73db6c8 into master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleCI can test Win 64 builds
2 participants