Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for eslint 4 #14

Closed
chrisbreiding opened this issue Dec 13, 2018 · 2 comments · Fixed by #49
Closed

Add support for eslint 4 #14

chrisbreiding opened this issue Dec 13, 2018 · 2 comments · Fixed by #49
Labels
released

Comments

@chrisbreiding
Copy link
Contributor

The new rules introduced in 2.1.0 only support eslint 5 and cause errors in eslint 4. Add backwards compatibility with eslint 4 so that the recommended rules can be used with it.
@chrisbreiding chrisbreiding mentioned this issue Dec 13, 2018
Closed
@maddhruv
Copy link
Contributor

Raised a PR for no-assigning-return-value fix - #49, which also fixes all tests for eslint@4.x.x

@maddhruv maddhruv mentioned this issue Feb 19, 2020
Merged
chrisbreiding added a commit that referenced this issue Feb 19, 2020
@chrisbreiding
fix: Add support for eslint 4 to no-assigning-return-values rule
46bf46a 
fix: no-assigning-return-values eslint 4, Resolves #14
@chrisbreiding
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 mentioned this issue Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: no-assigning-return-values eslint 4, Resolves #14 maddhruv/eslint-plugin-cypress
2 participants
@chrisbreiding @maddhruv