Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no-assigning-return-values eslint 4, Resolves #14 #49

Merged
merged 1 commit into from Feb 19, 2020
Merged

fix: no-assigning-return-values eslint 4, Resolves #14 #49

merged 1 commit into from Feb 19, 2020

Conversation

maddhruv
Copy link
Contributor

@maddhruv maddhruv commented Feb 19, 2020 •
edited

Add support for ESLint v4
Resolves #14

Steps to Test

  • npm i eslint@4.x.x
  • npm start

Ref

@maddhruv maddhruv mentioned this pull request Feb 19, 2020
Closed
@maddhruv maddhruv changed the title fix: no-assigning-return-values eslint 4 fix: no-assigning-return-values eslint 4, Resolves #14 Feb 19, 2020
@maddhruv
Copy link
Contributor Author

Will add eslint@4.x.x CI tests after the PR is approved and merged

@chrisbreiding
Copy link
Contributor

Why wait to add tests? I'd rather they be part of this PR to verify this works.

@maddhruv
Copy link
Contributor Author

I want to separate the concerns for both the jobs (this support PR and CI jobs)

@chrisbreiding chrisbreiding merged commit 46bf46a into cypress-io:master Feb 19, 2020
@chrisbreiding
Copy link
Contributor

🎉 This PR is included in version 2.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maddhruv maddhruv deleted the fix/no-assigning-return-values-eslint-4 branch February 19, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbreiding chrisbreiding Awaiting requested review from chrisbreiding

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for eslint 4
2 participants
@maddhruv @chrisbreiding