SQLite & MySQL: improve perf of Set operations with first-write-wins #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the needs to start a transaction with 2 queries, using a single, atomic query instead. This avoids locking the database for longer (in SQLite, transactions lock the entire database), and reduces the number of round-trips to the DB from 4 to 1. Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
changed the title
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 9c6c9e1 |
Components certification testCommit ref: 9c6c9e1 ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 9c6c9e1 ✅ All conformance tests passedAll tests have reported a successful status |
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
…nto sqlite-improv
Signed-off-by: Bernd Verst <github@bernd.dev>
berndverst
approved these changes
Nov 1, 2023
ItalyPaleAle
added a commit
to ItalyPaleAle/dapr-components-contrib
that referenced
this pull request
Nov 2, 2023
dapr#3159 introduced a regression that caused sets with first-write-wins fail if the table was empty The issue was due to a "FROM" statement in the CTE that should not have been there. Also improved how the SQLite component detects etag failures when FWW is used Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MySQL & SQLite state stores, improves the performance of Set operations that use first-write wins (common in actors).
This is done by avoiding the need to start a transaction with 2 queries (SQLite) or a stored procedure (MySQL), using a single, atomic query that uses a Common Table Expression instead.
This avoids locking the database for longer (in SQLite, transactions lock the entire database), and reduces the number of round-trips to the DB from (up to) 4 to 1.