Allow specifying control plane service for actors and/or reminders #7318

DeepanshuA · 2023-12-19T17:27:20Z

Description

This PR lets users configure their solution/ControlPlaneService for actors/reminders.
If nothing is given, traditional placement and inbuilt reminders will be used.

Issue reference

Please reference the issue this PR links with: #7203

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Unit tests passing
End-to-end tests passing
Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Co-authored-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

codecov · 2023-12-21T14:29:02Z

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (525a3de) 62.12% compared to head (6591003) 62.10%.

Files	Patch %	Lines
pkg/injector/service/config.go	63.63%	9 Missing and 3 partials ⚠️
pkg/injector/service/pod_patch.go	46.66%	5 Missing and 3 partials ⚠️
pkg/actors/actors.go	45.45%	3 Missing and 3 partials ⚠️
pkg/injector/patcher/sidecar_container.go	0.00%	2 Missing and 2 partials ⚠️
cmd/daprd/options/options.go	66.66%	1 Missing and 1 partial ⚠️
pkg/injector/patcher/services.go	81.81%	1 Missing and 1 partial ⚠️
pkg/runtime/runtime.go	93.93%	1 Missing and 1 partial ⚠️
pkg/runtime/processor/state/state.go	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7318      +/-   ##
==========================================
- Coverage   62.12%   62.10%   -0.03%     
==========================================
  Files         239      240       +1     
  Lines       21967    22059      +92     
==========================================
+ Hits        13648    13699      +51     
- Misses       7184     7214      +30     
- Partials     1135     1146      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

…_deploy Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

…_deploy Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

ItalyPaleAle · 2024-01-04T15:58:32Z

/ok-to-test

ItalyPaleAle · 2024-01-04T15:58:38Z

/test-version-skew

dapr-bot · 2024-01-04T15:58:56Z

Dapr E2E test

🔗 Link to Action run

Commit ref: 5304c2b

✅ Build succeeded for linux/amd64

Image tag: dapre2e2728e708b6l
Test image tag: dapre2e2728e708b6l

✅ Infrastructure deployed

Cluster	Resource group name	Azure region
Linux	`Dapr-E2E-dapre2e2728e708b6l`	westus3
Windows	`Dapr-E2E-dapre2e2728e708b6w`	westus3
Linux/arm64	`Dapr-E2E-dapre2e2728e708b6la`	eastus

✅ Build succeeded for windows/amd64

Image tag: dapre2e2728e708b6w
Test image tag: dapre2e2728e708b6w

✅ Tests succeeded on windows/amd64

Image tag: dapre2e2728e708b6w
Test image tag: dapre2e2728e708b6w

✅ Tests succeeded on linux/amd64

Image tag: dapre2e2728e708b6l
Test image tag: dapre2e2728e708b6l

dapr-bot · 2024-01-04T15:59:04Z

Dapr Version Skew test (control-plane-master - 1.12.3)

🔗 Link to Action run

Commit ref: 5304c2b

✅ Version Skew tests passed

dapr-bot · 2024-01-04T15:59:04Z

Dapr Version Skew test (dapr-sidecar-master - 1.12.3)

🔗 Link to Action run

Commit ref: 5304c2b

✅ Version Skew tests passed

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

mukundansundar · 2024-01-16T14:16:54Z

/test-version-skew

mukundansundar · 2024-01-16T14:17:02Z

/ok-to-test

mukundansundar · 2024-01-16T14:17:05Z

/ok-to-test

dapr-bot · 2024-01-16T14:17:20Z

Dapr Version Skew e2e test (control-plane-master - 1.12.3)

🔗 Link to Action run

Commit ref: 3daed2d

✅ Version Skew tests passed

dapr-bot · 2024-01-16T14:17:22Z

Dapr Version Skew integration test (control-plane-master - 1.12.3)

🔗 Link to Action run

Commit ref: 3daed2d

✅ Version Skew tests passed

dapr-bot · 2024-01-16T14:17:34Z

Dapr E2E test

🔗 Link to Action run

Commit ref: 3daed2d

✅ Build succeeded for linux/amd64

Image tag: dapre2e891cf2575al
Test image tag: dapre2e891cf2575al

✅ Infrastructure deployed

Cluster	Resource group name	Azure region
Linux	`Dapr-E2E-dapre2e891cf2575al`	westus3
Windows	`Dapr-E2E-dapre2e891cf2575aw`	westus3
Linux/arm64	`Dapr-E2E-dapre2e891cf2575ala`	eastus

✅ Build succeeded for windows/amd64

Image tag: dapre2e891cf2575aw
Test image tag: dapre2e891cf2575aw

❌ Tests failed on windows/amd64

Please check the logs for details on the error.

❌ Tests failed on linux/amd64

Please check the logs for details on the error.

dapr-bot · 2024-01-16T14:17:36Z

Dapr E2E test

🔗 Link to Action run

Commit ref: 3daed2d

✅ Build succeeded for linux/amd64

Image tag: dapre2ef251cdc56dl
Test image tag: dapre2ef251cdc56dl

✅ Infrastructure deployed

Cluster	Resource group name	Azure region
Linux	`Dapr-E2E-dapre2ef251cdc56dl`	westus3
Windows	`Dapr-E2E-dapre2ef251cdc56dw`	westus3
Linux/arm64	`Dapr-E2E-dapre2ef251cdc56dla`	eastus

✅ Build succeeded for windows/amd64

Image tag: dapre2ef251cdc56dw
Test image tag: dapre2ef251cdc56dw

❌ Tests failed on linux/amd64

Please check the logs for details on the error.

❌ Tests failed on windows/amd64

Please check the logs for details on the error.

mukundansundar · 2024-01-16T15:15:47Z

/test-version-skew

dapr-bot · 2024-01-16T15:18:26Z

✅ Version Skew tests passed

dapr-bot · 2024-01-16T15:21:56Z

Dapr Version Skew integration test (dapr-sidecar-master - 1.12.3)

🔗 Link to Action run

Commit ref: 404acdd

✅ Version Skew tests passed

dapr-bot · 2024-01-16T15:44:57Z

❌ Version Skew tests failed

Please check the logs for details on the error.

dapr-bot · 2024-01-16T16:01:27Z

✅ Version Skew tests passed

dapr-bot · 2024-01-16T16:26:42Z

❌ Version Skew tests failed

Please check the logs for details on the error.

dapr-bot · 2024-01-16T16:28:32Z

✅ Version Skew tests passed

ItalyPaleAle and others added 5 commits December 18, 2023 18:55

Cherry-pick dapr#7029

bf2d819

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Pass Actors/Reminders options to daprd

95a25fc

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

Merge branch 'master' into cp_service_deploy

d52b8c2

Fixed passing actor service

71c3080

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

ItalyPaleAle changed the title ~~[WIP] Deploy a Control Plane Service for Actors/Reminders~~ [WIP] Allow specifying control plane service for actors and/or reminders Dec 19, 2023

ItalyPaleAle and others added 5 commits December 19, 2023 18:00

Also pass remindersService configuration

52bf970

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Merge branch 'master' into cp_service_deploy

13aa40e

Merge branch 'master' into cp_service_deploy

05ad882

go.mod change

737ccd2

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

Revert

e955419

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

DeepanshuA and others added 6 commits December 21, 2023 20:02

Revert

d6bc461

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

Merge branch 'master' of https://github.com/dapr/dapr into cp_service…

e3c8a5e

…_deploy Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

placement address corection in tpl

3e91654

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

Merge branch 'master' into cp_service_deploy

9689773

Merge branch 'master' of https://github.com/dapr/dapr into cp_service…

f721813

…_deploy Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Auto-loading of placement and reminders providers

8027d5c

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

ItalyPaleAle changed the title ~~[WIP] Allow specifying control plane service for actors and/or reminders~~ Allow specifying control plane service for actors and/or reminders Jan 4, 2024

Small fixes

5304c2b

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

DeepanshuA marked this pull request as ready for review January 4, 2024 15:37

DeepanshuA requested review from a team as code owners January 4, 2024 15:37

ItalyPaleAle added 2 commits January 4, 2024 17:43

Fixed bug in injector

dd955ae

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Added log

990aec6

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

yaron2 and others added 3 commits January 15, 2024 11:36

Merge branch 'master' into cp_service_deploy

629c1b3

Merge branch 'master' into cp_service_deploy

fc4bf7a

Add headers

4659ab9

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>

DeepanshuA requested a review from JoshVanL January 16, 2024 11:35

Merge branch 'master' into cp_service_deploy

3daed2d

JoshVanL approved these changes Jan 16, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'master' into cp_service_deploy

404acdd

mukundansundar approved these changes Jan 16, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'master' into cp_service_deploy

6591003

mukundansundar merged commit 43d9f5a into dapr:master Jan 16, 2024
18 of 22 checks passed

Viktorsubota mentioned this pull request Jan 17, 2024

Issues 7103 add priority class to helm #7395

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow specifying control plane service for actors and/or reminders #7318

Allow specifying control plane service for actors and/or reminders #7318

DeepanshuA commented Dec 19, 2023 •

edited by ItalyPaleAle

codecov bot commented Dec 21, 2023 •

edited

ItalyPaleAle commented Jan 4, 2024

ItalyPaleAle commented Jan 4, 2024

dapr-bot commented Jan 4, 2024 •

edited

dapr-bot commented Jan 4, 2024 •

edited

dapr-bot commented Jan 4, 2024 •

edited

mukundansundar commented Jan 16, 2024

mukundansundar commented Jan 16, 2024

mukundansundar commented Jan 16, 2024

This comment has been minimized.

This comment has been minimized.

dapr-bot commented Jan 16, 2024 •

edited

dapr-bot commented Jan 16, 2024 •

edited

dapr-bot commented Jan 16, 2024 •

edited

dapr-bot commented Jan 16, 2024 •

edited

mukundansundar commented Jan 16, 2024

dapr-bot commented Jan 16, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dapr-bot commented Jan 16, 2024 •

edited

dapr-bot commented Jan 16, 2024

dapr-bot commented Jan 16, 2024

dapr-bot commented Jan 16, 2024

dapr-bot commented Jan 16, 2024

Allow specifying control plane service for actors and/or reminders #7318

Allow specifying control plane service for actors and/or reminders #7318

Conversation

DeepanshuA commented Dec 19, 2023 • edited by ItalyPaleAle

Description

Issue reference

Checklist

codecov bot commented Dec 21, 2023 • edited

Codecov Report

ItalyPaleAle commented Jan 4, 2024

ItalyPaleAle commented Jan 4, 2024

dapr-bot commented Jan 4, 2024 • edited

Dapr E2E test

✅ Build succeeded for linux/amd64

✅ Infrastructure deployed

✅ Build succeeded for windows/amd64

✅ Tests succeeded on windows/amd64

✅ Tests succeeded on linux/amd64

dapr-bot commented Jan 4, 2024 • edited

Dapr Version Skew test (control-plane-master - 1.12.3)

✅ Version Skew tests passed

dapr-bot commented Jan 4, 2024 • edited

Dapr Version Skew test (dapr-sidecar-master - 1.12.3)

✅ Version Skew tests passed

mukundansundar commented Jan 16, 2024

mukundansundar commented Jan 16, 2024

mukundansundar commented Jan 16, 2024

This comment has been minimized.

This comment has been minimized.

dapr-bot commented Jan 16, 2024 • edited

Dapr Version Skew e2e test (control-plane-master - 1.12.3)

✅ Version Skew tests passed

dapr-bot commented Jan 16, 2024 • edited

Dapr Version Skew integration test (control-plane-master - 1.12.3)

✅ Version Skew tests passed

dapr-bot commented Jan 16, 2024 • edited

Dapr E2E test

✅ Build succeeded for linux/amd64

✅ Infrastructure deployed

✅ Build succeeded for windows/amd64

❌ Tests failed on windows/amd64

❌ Tests failed on linux/amd64

dapr-bot commented Jan 16, 2024 • edited

Dapr E2E test

✅ Build succeeded for linux/amd64

✅ Infrastructure deployed

✅ Build succeeded for windows/amd64

❌ Tests failed on linux/amd64

❌ Tests failed on windows/amd64

mukundansundar commented Jan 16, 2024

dapr-bot commented Jan 16, 2024

✅ Version Skew tests passed

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dapr-bot commented Jan 16, 2024 • edited

Dapr Version Skew integration test (dapr-sidecar-master - 1.12.3)

✅ Version Skew tests passed

dapr-bot commented Jan 16, 2024

❌ Version Skew tests failed

dapr-bot commented Jan 16, 2024

✅ Version Skew tests passed

dapr-bot commented Jan 16, 2024

❌ Version Skew tests failed

dapr-bot commented Jan 16, 2024

✅ Version Skew tests passed

DeepanshuA commented Dec 19, 2023 •

edited by ItalyPaleAle

codecov bot commented Dec 21, 2023 •

edited

dapr-bot commented Jan 4, 2024 •

edited

dapr-bot commented Jan 4, 2024 •

edited

dapr-bot commented Jan 4, 2024 •

edited

dapr-bot commented Jan 16, 2024 •

edited

dapr-bot commented Jan 16, 2024 •

edited

dapr-bot commented Jan 16, 2024 •

edited

dapr-bot commented Jan 16, 2024 •

edited

dapr-bot commented Jan 16, 2024 •

edited