New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubSub API: standardize err msgs #7322
Conversation
pkg/http/api_test.go
Outdated
@@ -302,7 +303,7 @@ func TestPubSubEndpoints(t *testing.T) { | |||
// assert | |||
assert.Equal(t, 403, resp.StatusCode, "unexpected success publishing with %s", method) | |||
assert.Equal(t, "ERR_PUBSUB_FORBIDDEN", resp.ErrorBody["errorCode"]) | |||
assert.Equal(t, "topic topic is not allowed for app id test", resp.ErrorBody["message"]) //nolint:dupword | |||
assert.Equal(t, "topic topic is not allowed for app id fakeAPI", resp.ErrorBody["message"]) //nolint:dupword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be fakeAPI
, as if you look that is the app id that is set for the test. test
is the pubsub name I believe, so I made it the true app id name.
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
…ion tests Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
1160edb
to
936178c
Compare
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle had a thought like instead of keeping under |
…ubOutbox test w/ pluggable pubsub Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Does any of the current reviewers have any concern before I merge this? |
/test-sdk-all |
Dapr SDK Python testCommit ref: d68b1d8 ✅ Python SDK tests passed |
Dapr SDK Java testCommit ref: d68b1d8 ❌ Java SDK tests failedPlease check the logs for details on the error. |
Dapr SDK Go testCommit ref: d68b1d8 ✅ Go SDK tests passed |
Dapr SDK JS testCommit ref: d68b1d8 ✅ JS SDK tests passed |
If you look at the commit right before your comment, that's where I added the 'fix'. Its the actor health that is failing for me on Windows. I assume that is somewhat flaky bc I've seen it before. |
Description
Making this a draft since I need to add integration tests.
This is the code to standardize many of the PubSub api errors to use the newly merged kit pkg for standardizing errors around the richer error model based on this proposal: https://github.com/dapr/proposals/blob/main/0009-BCIRS-error-handling-codes.md.
I added todos for a follow up PR to enrich more of the pubsub errors, as there were already so many that were updated in this PR.
Issue Reference
#6068
Checklist