Fix vnode calculation in placement clients. #7415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vnode response to placement clients to be backwards compatible. Makes the API level check based on cluster level, rather than on a per request basis. Remove placement API level gRPC context metadata. Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
changed the title
|
/test-version-skew |
Dapr Version Skew e2e test (dapr-sidecar-master - 1.12.4)Commit ref: f8fe403 ✅ Version Skew tests passed |
Dapr Version Skew integration test (dapr-sidecar-master - 1.12.4)Commit ref: f8fe403 ✅ Version Skew tests passed |
Dapr Version Skew e2e test (control-plane-master - 1.12.4)Commit ref: f8fe403 ✅ Version Skew tests passed |
Dapr Version Skew integration test (control-plane-master - 1.12.4)Commit ref: f8fe403 ✅ Version Skew tests passed |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7415 +/- ##
=======================================
Coverage 62.24% 62.24%
=======================================
Files 240 240
Lines 22137 22111 -26
=======================================
- Hits 13779 13763 -16
+ Misses 7208 7199 -9
+ Partials 1150 1149 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: joshvanl <me@joshvanl.dev>
artursouza
approved these changes
Jan 19, 2024
whytem
pushed a commit
to whytem/dapr
that referenced
this pull request
Jan 22, 2024
* Fix vnode response to placement clients. Fixes vnode response to placement clients to be backwards compatible. Makes the API level check based on cluster level, rather than on a per request basis. Remove placement API level gRPC context metadata. Signed-off-by: joshvanl <me@joshvanl.dev> * Fix method used in int sa grpc test Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev>
elena-kolevska
added a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 23, 2024
This reverts commit 38fb965. Signed-off-by: Elena Kolevska <elena@kolevska.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vnode response to placement clients to be backwards compatible. Makes the API level check based on cluster level, rather than on a per request basis. Remove placement API level gRPC context metadata.
Fix piping the replication factor config to consistent hashing.
Use local hashing in daprd based on the placement API level of the cluster.
We still need to add integration tests which check the contents on the placement decimation response for the expected presence of vnodes, and the current expected API level.