New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement service lock optimisations and race condition fix #7428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7428 +/- ##
==========================================
+ Coverage 62.31% 62.32% +0.01%
==========================================
Files 240 240
Lines 22070 22077 +7
==========================================
+ Hits 13752 13760 +8
+ Misses 7178 7173 -5
- Partials 1140 1144 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska
commented
Jan 26, 2024
@@ -48,7 +48,7 @@ type placementClient struct { | |||
|
|||
// connectToServer initializes a new connection to the target server and if it succeeds replace the current | |||
// stream with the connected stream. | |||
func (c *placementClient) connectToServer(ctx context.Context, serverAddr string, apiLevel uint32) error { | |||
func (c *placementClient) connectToServer(ctx context.Context, serverAddr string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a leftover cleanup from #7415
elena-kolevska
changed the title
Calculates vnode hashes outside of lock
Placement service lock optimisations and race condition fix
Jan 26, 2024
…k inside of the method itself Signed-off-by: Elena Kolevska <elena@kolevska.com>
…nto macos-actors-tests
JoshVanL
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a few placement service optimisations:
A race condition fix:
resetPlacementTables
method was called without a lock from two places - on actor placement start and on reconnection to the placement service.This PR It also clean ups the
apiLevel
parameter from theconnectToServer
method, because it's not used anymore.Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: