Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement service lock optimisations and race condition fix #7428

Merged
merged 14 commits into from
Jan 26, 2024

Commits on Jan 22, 2024

  1. Calculates vnode hashes outside of lock

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    fdf4f1c View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Checks version again after reacquiring lock

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3855a57 View commit details
    Browse the repository at this point in the history
  2. Removes unneeded check.

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3e073eb View commit details
    Browse the repository at this point in the history
  3. Reduce the time we’re holding the lock on the Consistent hash

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    729710e View commit details
    Browse the repository at this point in the history
  4. Fixes possible race condition

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    2c9265d View commit details
    Browse the repository at this point in the history
  5. Prevents possible race condition

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    19c3e77 View commit details
    Browse the repository at this point in the history
  6. Another possible race condition

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    40c73a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Removes leftover context metadata

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    98317de View commit details
    Browse the repository at this point in the history
  2. Small refactor

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    41ab644 View commit details
    Browse the repository at this point in the history
  3. Removes comment cause it’s not needed anymore, after bringing the loc…

    …k inside of the method itself
    
    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f3c3c9a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a84b2f5 View commit details
    Browse the repository at this point in the history
  5. Revert

    Signed-off-by: Elena Kolevska <elena@kolevska.com>
    elena-kolevska committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f658f98 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3eab372 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    03c2181 View commit details
    Browse the repository at this point in the history