Workflow delete: Remove non_recursive with hardcoded always enabled recursive
#7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow terminate and purge APIs currently take a `non_recursive` parameter to indicate whether to delete the workflow and its children. This is a double negative and is confusing for users, needing a few more brain cycles to understand the field. We should avoid double negatives in APIs. This PR changes the parameter to `recursive` to make it more clear. `recursive` defaults to `true`. Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
added a commit
to JoshVanL/dapr-docs
that referenced
this pull request
Feb 5, 2024
Updates from PR dapr/dapr#7498 Signed-off-by: joshvanl <me@joshvanl.dev>
ItalyPaleAle
requested changes
Feb 5, 2024
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
changed the title
non_recursive to recursivenon_recursive with hardcoded always enabled recursive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7498 +/- ##
==========================================
- Coverage 62.12% 62.12% -0.01%
==========================================
Files 245 245
Lines 22346 22336 -10
==========================================
- Hits 13883 13876 -7
+ Misses 7303 7302 -1
+ Partials 1160 1158 -2 ☔ View full report in Codecov by Sentry. |
2 tasks
mukundansundar
approved these changes
Feb 6, 2024
ItalyPaleAle
approved these changes
Feb 6, 2024
msfussell
added a commit
to dapr/docs
that referenced
this pull request
Feb 9, 2024
* Updates workflow terminate/purge `non_recursive` query to `recursive` Updates from PR dapr/dapr#7498 Signed-off-by: joshvanl <me@joshvanl.dev> * Removes recursive workflow delete strategy from API completely Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Mark Fussell <markfussell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow terminate and purge APIs currently take a
non_recursiveparameter to indicate whether to delete the workflow and its children. This is a double negative and is confusing for users, needing a few more brain cycles to understand the field. We should avoid double negatives in APIs.Removes this option so that
recursiveis always enabled with no API field exposing the option.