Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow delete: Remove non_recursive with hardcoded always enabled recursive #7498

Merged

Commits on Feb 5, 2024

  1. Workflow delete: Change double negative non_recursive to recursive

    The workflow terminate and purge APIs currently take a `non_recursive`
    parameter to indicate whether to delete the workflow and its children.
    This is a double negative and is confusing for users, needing a few more
    brain cycles to understand the field. We should avoid double negatives
    in APIs. This PR changes the parameter to `recursive` to make it more
    clear.
    
    `recursive` defaults to `true`.
    
    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e348867 View commit details
    Browse the repository at this point in the history
  2. Linting

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    c6748b9 View commit details
    Browse the repository at this point in the history
  3. Linting

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    6e88079 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Completely remove option for recursive workflow deletion

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e6e7215 View commit details
    Browse the repository at this point in the history
  2. Linting

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    be48cee View commit details
    Browse the repository at this point in the history
  3. Linting

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4690d6c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7146225 View commit details
    Browse the repository at this point in the history