New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework toDate and extract parseISO #1023
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6ed5b2f
Rework toDate and extract parseISO
kossnocorp b4b325b
Get rid of global options object
kossnocorp cf53019
Regenerate library with removed options
kossnocorp 0e1ecd7
Update docs to reflect extracted parseISO and removed options
kossnocorp 37bb142
Fix bug in gl locale
kossnocorp 838ed9f
Fix DST issue in eachDayOfInterval
kossnocorp f5e9835
Address review comments
kossnocorp File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// This is basic DST test for eachDayOfInterval | ||
|
||
import eachDayOfInterval from '../../../src/eachDayOfInterval' | ||
import assert from 'assert' | ||
|
||
if (process.env.TZ !== 'Asia/Damascus') | ||
throw new Error('The test must be run with TZ=Asia/Damascus') | ||
|
||
if (parseInt(process.version.match(/^v(\d+)\./)[1]) < 10) | ||
throw new Error('The test must be run on Node.js version >= 10') | ||
|
||
assert.deepEqual( | ||
eachDayOfInterval({ | ||
start: new Date(2020, 2, 26), | ||
end: new Date(2020, 2, 28) | ||
}).map(d => d.toString()), | ||
[ | ||
'Thu Mar 26 2020 00:00:00 GMT+0200 (Eastern European Standard Time)', | ||
'Fri Mar 27 2020 01:00:00 GMT+0300 (Eastern European Summer Time)', | ||
'Sat Mar 28 2020 00:00:00 GMT+0300 (Eastern European Summer Time)' | ||
] | ||
) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've messed up with the rebase, so for those who are looking for the actual fix: https://github.com/date-fns/date-fns/pull/1023/files#diff-5a48fe3ae25f8ac62336262cb0acd5e2