Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corner cases #460

Merged
merged 30 commits into from Apr 6, 2017
Merged

Fix corner cases #460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4a86f69
Invalid Date tests for `addX`, `setX` and `subX`
leshakoss Mar 10, 2017
c2ad9aa
Invalid Date tests for `getX`
leshakoss Mar 10, 2017
7198e72
Invalid Date tests for `startOfX`, `endOfX` and `lastDayOfX`
leshakoss Mar 10, 2017
bdf0fe6
Invalid Date tests for `isSameX`
leshakoss Mar 10, 2017
23bf5cc
Invalid Date tests for `differenceInX`
leshakoss Mar 10, 2017
a221f1d
`isX(new Date(NaN))` tests
leshakoss Mar 10, 2017
a29d4c1
`isAfter`, `isBefore` and `isEqual` Invalid Date tests
leshakoss Mar 10, 2017
76a7ee9
Interval functions Invalid Date tests
leshakoss Mar 10, 2017
f95be8d
`compareAsc` and `compareDesc` Invalid Date tests
leshakoss Mar 10, 2017
e37f161
`closestTo`, `closestIndexTo`, `max` and `min` Invalid Date tests
leshakoss Mar 10, 2017
6f1ad3c
Test `toDate` if `options.additionalDigits` is not 0, 1, 2 or undefined
leshakoss Mar 10, 2017
55d8f13
Test `parse` if baseDate is `Invalid Date`
leshakoss Mar 10, 2017
f5d8974
`distanceInWords` and `distanceInWordsStrict` invalid values tests
leshakoss Mar 10, 2017
638588c
Invalid `options.weekStartsOn` tests
leshakoss Mar 10, 2017
0a4ae92
Invalid value implementation fixes
leshakoss Mar 10, 2017
f16abd9
`parse` implementation fix
leshakoss Apr 4, 2017
2dfc42b
`weekStartsOn` implementation fix
leshakoss Apr 4, 2017
32e6716
Rename `partialMethod` to `roundingMethod`
leshakoss Mar 9, 2017
94aa54c
`distanceInWordsStrict` implementation fix
leshakoss Apr 4, 2017
57c0bfb
Rebuild typings
leshakoss Apr 4, 2017
fefcf91
`toDate` implementation fix
leshakoss Apr 4, 2017
c56f2a4
Add CHANGELOG.md entry
leshakoss Apr 4, 2017
d6dbf1e
Add missing tests
leshakoss Apr 5, 2017
5bdbb46
Make interval functions throw RangeError
leshakoss Apr 5, 2017
e077e09
Fix @throws docs messages
leshakoss Apr 5, 2017
9c6c6f7
Add `@throws {RangeError}` to all functions docs
leshakoss Apr 5, 2017
e5df225
Add `@param [options.additionalDigits]` to all functions docs
leshakoss Apr 5, 2017
edaf164
Add `options.additionalDigits` tests to all functions
leshakoss Apr 5, 2017
202ba04
Complete corner cases changelog entry
leshakoss Apr 5, 2017
4318f37
Add missing `$ExpectedMistake`
leshakoss Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/isAfter/test.js
View file
Open in desktop
Expand Up @@ -44,4 +44,20 @@ describe('isAfter', function () {
)
assert(result === true)
})

it('returns false if the first date is `Invalid Date`', function () {
var result = isAfter(
new Date(NaN),
new Date(1989, 6 /* Jul */, 10)
)
assert(result === false)
})

it('returns false if the second date is `Invalid Date`', function () {
var result = isAfter(
new Date(1987, 1 /* Feb */, 11),
new Date(NaN)
)
assert(result === false)
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test case for isAfter(new Date(NaN), new Date(NaN))

})
16 changes: 16 additions & 0 deletions src/isBefore/test.js
View file
Open in desktop
Expand Up @@ -44,4 +44,20 @@ describe('isBefore', function () {
)
assert(result === true)
})

it('returns false if the first date is `Invalid Date`', function () {
var result = isBefore(
new Date(NaN),
new Date(1989, 6 /* Jul */, 10)
)
assert(result === false)
})

it('returns false if the second date is `Invalid Date`', function () {
var result = isBefore(
new Date(1987, 1 /* Feb */, 11),
new Date(NaN)
)
assert(result === false)
})
})
16 changes: 16 additions & 0 deletions src/isEqual/test.js
View file
Open in desktop
Expand Up @@ -36,4 +36,20 @@ describe('isEqual', function () {
)
assert(result === true)
})

it('returns false if the first date is `Invalid Date`', function () {
var result = isEqual(
new Date(NaN),
new Date(1989, 6 /* Jul */, 10)
)
assert(result === false)
})

it('returns false if the second date is `Invalid Date`', function () {
var result = isEqual(
new Date(1987, 1 /* Feb */, 11),
new Date(NaN)
)
assert(result === false)
})
})