New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix corner cases #460
Merged
Merged
Fix corner cases #460
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
4a86f69
Invalid Date tests for `addX`, `setX` and `subX`
leshakoss c2ad9aa
Invalid Date tests for `getX`
leshakoss 7198e72
Invalid Date tests for `startOfX`, `endOfX` and `lastDayOfX`
leshakoss bdf0fe6
Invalid Date tests for `isSameX`
leshakoss 23bf5cc
Invalid Date tests for `differenceInX`
leshakoss a221f1d
`isX(new Date(NaN))` tests
leshakoss a29d4c1
`isAfter`, `isBefore` and `isEqual` Invalid Date tests
leshakoss 76a7ee9
Interval functions Invalid Date tests
leshakoss f95be8d
`compareAsc` and `compareDesc` Invalid Date tests
leshakoss e37f161
`closestTo`, `closestIndexTo`, `max` and `min` Invalid Date tests
leshakoss 6f1ad3c
Test `toDate` if `options.additionalDigits` is not 0, 1, 2 or undefined
leshakoss 55d8f13
Test `parse` if baseDate is `Invalid Date`
leshakoss f5d8974
`distanceInWords` and `distanceInWordsStrict` invalid values tests
leshakoss 638588c
Invalid `options.weekStartsOn` tests
leshakoss 0a4ae92
Invalid value implementation fixes
leshakoss f16abd9
`parse` implementation fix
leshakoss 2dfc42b
`weekStartsOn` implementation fix
leshakoss 32e6716
Rename `partialMethod` to `roundingMethod`
leshakoss 94aa54c
`distanceInWordsStrict` implementation fix
leshakoss 57c0bfb
Rebuild typings
leshakoss fefcf91
`toDate` implementation fix
leshakoss c56f2a4
Add CHANGELOG.md entry
leshakoss d6dbf1e
Add missing tests
leshakoss 5bdbb46
Make interval functions throw RangeError
leshakoss e077e09
Fix @throws docs messages
leshakoss 9c6c6f7
Add `@throws {RangeError}` to all functions docs
leshakoss e5df225
Add `@param [options.additionalDigits]` to all functions docs
leshakoss edaf164
Add `options.additionalDigits` tests to all functions
leshakoss 202ba04
Complete corner cases changelog entry
leshakoss 4318f37
Add missing `$ExpectedMistake`
leshakoss File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add test case when the given array contains an unexpected value such as
undefined
.