Create user notifications while seeding

[alecslupu]

🎩 What? Why?

Currently, Decidim is not adding user notifications while seeding, making it hard for users to actually see the notication page functionality.

This PR adds the Comments, Proposals and Meetings created in the Participatory Processes to the notifications list.

Testing

1. Reseed your db or create a new dev app
2. Boot the application
3. Login as admin
4. Visit notifications page
5. See there are no notifications
6. Apply Patch
7. Repeat steps 1,2,3 and 4
8. See there are notifications

♥️ Thank you!

[andreslucena]

@alecslupu I might be doing something wrong, but I can't see the seeded notifications as admin@example.org:

[andreslucena]

@alecslupu can you check the failing spec? I can confirm that there's the same error by seeding manually (bin/rails db:drop db:create db:migrate db:seed)

[alecslupu]

@alecslupu can you check the failing spec? I can confirm that there's the same error by seeding manually (bin/rails db:drop db:create db:migrate db:seed)

It is a very peculiar situation, as the validation fails with no organization set. I have investigated, and seems there are is an issue that i do not understand yet, as we have the same class with 2 different object ids.

    pp record.organization.class.object_id => 69660
    pp Decidim::Organization.object_id => 100620

[alecslupu]

@alecslupu can you check the failing spec? I can confirm that there's the same error by seeding manually (bin/rails db:drop db:create db:migrate db:seed)

It is a very peculiar situation, as the validation fails with no organization set. I have investigated, and seems there are is an issue that i do not understand yet, as we have the same class with 2 different object ids.

    pp record.organization.class.object_id => 69660
    pp Decidim::Organization.object_id => 100620

More insteresting is that if i run bin/rails db:seed there is no error!

[andreslucena]

More insteresting is that if i run bin/rails db:seed there is no error!

I could reproduce it in Gitpod, I don't know if that's relevant. I can try tomorrow with my desktop

[andreslucena]

I could reproduce it in Gitpod, I don't know if that's relevant. I can try tomorrow with my desktop

I could play a bit more with this PR today. The buggy line is the change in the ActiveJob queue:

decidim/decidim-core/lib/decidim/core/seeds.rb

Line 16 in 6cf5bd1

ActiveJob::Base.queue_adapter = :inline

By applying that change in develop and then running reseding:

bin/rails db:drop db:create db:migrate db:seed

I have the same exception.

More insteresting is that if i run bin/rails db:seed there is no error!

On this case (i.e. having that line, and running)

bin/rails db:drop db:create db:migrate
bin/rails db:seed

Gives me another exception:

Running via Spring preloader in process 396681
Creating seeds for decidim-core...
rake aborted!
Errno::ECONNREFUSED: Failed to open TCP connection to localhost:3000 (Connection refused - connect(2) for "localhost" port 3000) (Errno::ECONNREFUSED)
/home/apereira/Work/decidim/decidim/decidim-core/app/models/decidim/user.rb:315:in `send_devise_notification'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core/seeds.rb:58:in `call'
/home/apereira/Work/decidim/decidim/decidim-core/db/seeds.rb:5:in `<main>'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:151:in `block in seed!'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:148:in `each'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:148:in `seed!'
/home/apereira/Work/decidim/decidim/development_app/db/seeds.rb:9:in `<main>'
<internal:/home/apereira/.local/share/mise/installs/ruby/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
<internal:/home/apereira/.local/share/mise/installs/ruby/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
-e:1:in `<main>'

Caused by:
Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 3000 (Errno::ECONNREFUSED)
/home/apereira/Work/decidim/decidim/decidim-core/app/models/decidim/user.rb:315:in `send_devise_notification'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core/seeds.rb:58:in `call'
/home/apereira/Work/decidim/decidim/decidim-core/db/seeds.rb:5:in `<main>'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:151:in `block in seed!'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:148:in `each'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:148:in `seed!'
/home/apereira/Work/decidim/decidim/development_app/db/seeds.rb:9:in `<main>'
<internal:/home/apereira/.local/share/mise/installs/ruby/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
<internal:/home/apereira/.local/share/mise/installs/ruby/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
-e:1:in `<main>'
Tasks: TOP => db:seed
(See full trace by running task with --trace)

[andreslucena]

@alecslupu I still have this error when running the seeds:

Creating seeds for decidim-core...
rake aborted!
Errno::ECONNREFUSED: Failed to open TCP connection to localhost:3000 (Connection refused - connect(2) for "localhost" port 3000) (Errno::ECONNREFUSED)
/home/apereira/Work/decidim/decidim/decidim-core/app/models/decidim/user.rb:315:in send_devise_notification' /home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core/seeds.rb:59:in call'
/home/apereira/Work/decidim/decidim/decidim-core/db/seeds.rb:5:in <main>' /home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:151:in block in seed!'
/home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:148:in each' /home/apereira/Work/decidim/decidim/decidim-core/lib/decidim/core.rb:148:in seed!'
/home/apereira/Work/decidim/decidim/development_app/db/seeds.rb:9:in <main>' <internal:/home/apereira/.local/share/mise/installs/ruby/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:136:in require'
internal:/home/apereira/.local/share/mise/installs/ruby/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb:136:in require' -e:1:in

'

Can you check it out please?

The command that I do is bin/rails db:drop db:create db:migrate db:seed

[andreslucena]

The command that I do is bin/rails db:drop db:create db:migrate db:seed

After seeing the changes in the code, I see that I need to do bin/rails db:drop db:create db:migrate assets:precompile db:seed. Now it works well, we should check out our docs to clarify this change whenever we mention the db:seeds command:

• docs/modules/develop/pages/guide_development_app.adoc
• docs/modules/install/pages/index.adoc
• docs/modules/install/pages/manual.adoc

[andreslucena]

I can confirm that it works as expected once I change the command for seeds. We need to add this change in the docs (see #12828 (comment)).

We should add it to the Releases Notes too to communicate to implementers/developers.