special/bin: climb up directories to find binary module

[sveyret]

Issue #436

[codecov]

Codecov Report

Merging #437 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          36       36           
  Lines         714      714           
=======================================
  Hits          708      708           
  Misses          6        6

Impacted Files	Coverage Δ
src/special/bin.js	100% <100%> (ø)	⬆️
src/index.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fa69c...3d305e5. Read the comment docs.

[sveyret]

Note that the same problem exists for ignoreBinPackages. I am about to update it too, please wait before merging.

[rumpl]

It would seem that you need to rebase your branch against master too

[rumpl]

Could you add a test too ?

[sveyret]

It would seem that you need to rebase your branch against master too

Are you sure? It says it is already up to date…

[rumpl]

Actually it fails because of the changes I made in a dependent build due to #433

As soon as that build passes I'll merge it and then you can rebase.

Please don't ask what is this dependent build, I'll work on removing it :)

[sveyret]

Here is the rebased version with modifications made also for ignoreBinPackages.
I still need to have a look to see if I can easily add tests.

[rumpl]

Some tests would be nice yes :)

Thank you for your work, it's appreciated

[sveyret]

I added tests and also made some other modifications:

• changed the per-directory .gitignore into a single one into the test directory (they all were the same)
• removed a test which was duplicate

Each of these modification are in a separate commit for if you do not want to take them.

[rumpl]

Thanks! I’ll take a look at it closely tomorrow but it looks good from my phone. Cheers

Also, happy halloween if you are into that kind of things :)

[rumpl]

Unrelated but I used to work in Annecy, tres belle ville :)

[sveyret]

@rumpl Just a reminder as you said you'd have a look at this one today… 😄

[rumpl]

Why did you remove this test?

[sveyret]

If I understood well, it's doing exactly the same thing as 2 tests above (report unused bin dependencies if ignoreBinPackage equal false).

[rumpl]

ooooh good catch!

[rumpl]

Thanks for all the work you have been doing lately!

[sveyret]

You're welcome. Actually, I'm just making it work for my project… 😉

[rumpl]

Need anything else or do you want me to make a release just for you?

[sveyret]

Well, I made everything I needed, so yes, if you can make a release, that'd be great!

[rumpl]

Lets get #451 in it too