chore(braille-roledescription): correct pass message #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Aug 22, 2023
| @@ -82,7 +82,7 @@ | |||
| "help": "ARIA roles used must conform to valid values" | |||
| }, | |||
| "aria-text": { | |||
| "description": "Ensures \"role=text\" is used on elements with no focusable descendants", | |||
| "description": "Ensures role=\"text\" is used on elements with no focusable descendants", | |||
There was a problem hiding this comment.
#4131 Seems this one didn't go through the git hook.
straker
approved these changes
Aug 22, 2023
ma10
added a commit
to ma10/axe-core
that referenced
this pull request
Aug 22, 2023
…ne with the changes introduced by PR dequelabs#4133
WilcoFiers
added a commit
that referenced
this pull request
Aug 29, 2023
* Chore(i18n): Update and correct Japanese translation Remove whitespaces between English words and Japanese characters as agreed previously: #3319 rules/accesskeys: wording change rules/aria-focus-hidden: wording change rules/aria-input-field-name/help: wording change rules/aria-roledescription/help: wording change rules/aria-text/description: make the location of the double-quotes consistent with the original text. rules/aria-toggle-field-name/help: change wording rules/aria-tooltip-name/description: wording change rules/aria-treeitem-name/description: wording changes rules/blink/help: correct translation rules/color-contrast-enhanced: correct translation rules/color-contrast: correct translation rules/css-orientation-lock/help: wording change rules/definition-list/help: correct translation rules/duplicate-id-active: wording changes rules/duplicate-id-aria/description: wording change rules/focus-order-semantics: correct translation rules/form-field-multiple-labels/help: wording change rules/frame-focusable-content: correct translation rules/frame-tested/help: change wording rules/frame-title: correct translation rules/hidden-content* correct translation rules/identical-links-same-purpose: correct translation rules/label-title-only/description: correct translation rules/landmark-complementary-is-top-level/help: wording change rules/landmark-one-main/description: correct translation rules/landmark-unique/description: correct translation. rules/link-in-text-block: correct translation rules/meta-refresh-no-exceptions: correct translation rules/meta-refresh: correct translation rules/meta-viewport-large/help: correct translation rules/meta-viewport: correct translation rules/nested-interactive: correct translation rules/no-autoplay-audio/help: correct translation rules/p-as-heading: correct translation rules/presentation-role-conflict: correct translation rules/role-img-alt: correct translation rules/scrollable-region-focusable: correct translation rules/svg-img-alt/help: correct translation rules/tabindex/help: correct translation rules/table-duplicate-name: correct translation rules/table-fake-caption/help: correct translation rules/target-size/help: correct translation rules/td-has-header: correct translation rules/td-headers-attr: correct translation rules/th-has-data-cells: swap the content of help and description to be consistent with the original. checks/aria-allowed-attr/incomplete: correct translation checks/aria-allowed-role/{fail,incomplete: correct translation checks/aria-busy/fail: correct translation checks/aria-errormessage{pass,fail}: correct translation checks/aria-required-children/fail/unallowed: sync with the en version checks/aria-allowed-attr/incomplete: correct translation checks/deprecatedrole/pass: correct translation checks/has-global-aria-attribute: correct translation checks/color-contrast-enhanced/incomplete/pseudoContent: consistent wording with other phrases checks/color-contrast/incomplete/pseudoContent: consistent wording with other phrases checks/pseudoContent/pass: consistent wording with other phrases checks/link-in-text-block/incomplete/{default,bgColorContrast}: correct translation checks/accesskeys: correct translation checks/focusable-disabled: correct translation checks/focusable-modal-open: correct translation checks/focusable-not-tabbable: correct translation checks/landmark-is-top-level/fail: correct translation checks/page-has-main/pass: correct translation checks/alt-space-value/fail: correct translation checks/explicit-label: correct translation checks/help-same-as-label: correct translation checks/hidden-explicit-label: correct translation checks/multiple-label/fail: correct translation checks/landmark-is-unique/pass: correct translation checks/listitem/fail/roleNotValid: correct translation checks/only-dlitems: correct translation checks/only-listitems: correct translation checks/caption/incomplete: correct translation checks/no-autoplay-audio: correct translation checks/css-orientation-lock: correct translation checks/target-offset: correct translation checks/target-size: correct translation checks/header-present: correct translation checks/identical-links-same-purpose/incomplete: correct translation checks/identical-links-same-purpose: correct translation Make the translation of the oword "present" consistent throughout the file. checks/meta-refresh-no-exceptions/fail: correct translation checks/meta-refresh/fail: correct translation checks/p-as-heading/fail: correct translation checks/duplicate-id-aria: correct translation checks/duplicate-id: correct translation checks/button-has-visible-text/{pass,fail}: correct translation checks/has-alt: correct translation checks/important-letter-spacing: correct translation checks/important-line-height: correct translation checks/important-word-spacing: correct translation checks/non-empty-alt/pass: correct translation checks/non-empty-if-present: correct translation checks/non-empty-placeholder: correct translation checks/non-empty-title: correct translation checks/non-empty-value: correct translation checks/presentational-role: correct translation checks/svg-non-empty-title: correct translation checks/caption-faked/pass: typo fix failureSummary/incompleteFallbackMessage: correct translation Make the translation for "role attribute" consistent throughout the file. Add ja translation for checks/aria-conditional-attr * Add translation for checks/link-in-text-block-style/incomplete * Add ja translation for rules/aria-deprecated-role * Add ja translation for checks/color-contrast/incomplete/complexTextShadows * Update locales/ja.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * checks/aria-allowed-role/imcomplete: make the wording consistent between singular and plural * Add translation for rules/aria-prohibited-attr * Add translations for rules/aria-braille-equivalent, rules/aria-conditional-attr, checks/braille-label-equivalent, and checks/braille-roledescription-equivalent * Update locales/ja.json Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * Update checks/braille-roledescription-equivalent/pass to make it inline with the changes introduced by PR #4133 * Correct the error in the previous commit. --------- Co-authored-by: Masafumi Max NAKANE <ma10@users.noreply.github.com> Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix copy/paste error on the pass message of braille-roledescription-equivalent. "Chore" instead of "fix" because this is unreleased.